[coreboot-gerrit] Change in coreboot[master]: nb/intel/x4x/rcven.c: Change the verbosity of some messages

Arthur Heymans (Code Review) gerrit at coreboot.org
Sat Dec 16 21:06:51 CET 2017


Arthur Heymans has uploaded this change for review. ( https://review.coreboot.org/22912


Change subject: nb/intel/x4x/rcven.c: Change the verbosity of some messages
......................................................................

nb/intel/x4x/rcven.c: Change the verbosity of some messages

Displaying the whole receive enable procedure should only be done if
CONFIG_DEBUG_RAM_SETUP is selected.

Change-Id: Ib568621e6d044624c1c0aeb6fb08945f561395c7
Signed-off-by: Arthur Heymans <arthur at aheymans.xyz>
---
M src/northbridge/intel/x4x/rcven.c
1 file changed, 10 insertions(+), 8 deletions(-)



  git pull ssh://review.coreboot.org:29418/coreboot refs/changes/12/22912/1

diff --git a/src/northbridge/intel/x4x/rcven.c b/src/northbridge/intel/x4x/rcven.c
index 4cd48df..c2b5ad6 100644
--- a/src/northbridge/intel/x4x/rcven.c
+++ b/src/northbridge/intel/x4x/rcven.c
@@ -138,7 +138,7 @@
 static int decr_coarse_low(u8 channel, u8 lane, u32 addr,
 			struct rec_timing *timing)
 {
-	printk(BIOS_DEBUG,
+	printk(RAM_DEBUG,
 		"  Decreasing coarse until high to low transition is found\n");
 	while (sampledqs(addr, lane, channel) != DQS_LOW) {
 		if (timing->coarse == 0) {
@@ -149,7 +149,7 @@
 		timing->coarse--;
 		program_timing(timing, channel, lane);
 	}
-	printk(BIOS_DEBUG, "    DQS low at coarse=%d medium=%d\n",
+	printk(RAM_DEBUG, "    DQS low at coarse=%d medium=%d\n",
 		timing->coarse, timing->medium);
 	return 0;
 }
@@ -157,7 +157,7 @@
 static int fine_search_dqs_high(u8 channel, u8 lane, u32 addr,
 				struct rec_timing *timing)
 {
-	printk(BIOS_DEBUG,
+	printk(RAM_DEBUG,
 		"  Increasing TAP until low to high transition is found\n");
 	/*
 	 * We use a do while loop since it happens that the strobe read
@@ -184,7 +184,7 @@
 		program_timing(timing, channel, lane);
 	} while (sampledqs(addr, lane, channel) != DQS_HIGH);
 
-	printk(BIOS_DEBUG, "    DQS high at coarse=%d medium=%d tap:%d\n",
+	printk(RAM_DEBUG, "    DQS high at coarse=%d medium=%d tap:%d\n",
 		timing->coarse, timing->medium, timing->tap);
 	return 0;
 }
@@ -193,7 +193,7 @@
 			struct rec_timing *timing)
 {
 	/* Look for DQS low, using quarter steps. */
-	printk(BIOS_DEBUG, "  Increasing medium until DQS LOW is found\n");
+	printk(RAM_DEBUG, "  Increasing medium until DQS LOW is found\n");
 	while (sampledqs(addr, lane, channel) != DQS_LOW) {
 		if (increase_medium(timing)) {
 			printk(BIOS_CRIT,
@@ -202,7 +202,7 @@
 		}
 		program_timing(timing, channel, lane);
 	}
-	printk(BIOS_DEBUG, "    DQS low at coarse=%d medium=%d\n",
+	printk(RAM_DEBUG, "    DQS low at coarse=%d medium=%d\n",
 		timing->coarse, timing->medium);
 	return 0;
 }
@@ -210,7 +210,7 @@
 				struct rec_timing *timing)
 {
 	/* Look for DQS high, using quarter steps. */
-	printk(BIOS_DEBUG, "  Increasing medium until DQS HIGH is found\n");
+	printk(RAM_DEBUG, "  Increasing medium until DQS HIGH is found\n");
 	while (sampledqs(addr, lane, channel) != DQS_HIGH) {
 		if (increase_medium(timing)) {
 			printk(BIOS_CRIT,
@@ -219,7 +219,7 @@
 		}
 		program_timing(timing, channel, lane);
 	}
-	printk(BIOS_DEBUG, "    DQS high at coarse=%d medium=%d\n",
+	printk(RAM_DEBUG, "    DQS high at coarse=%d medium=%d\n",
 		timing->coarse, timing->medium);
 	return 0;
 }
@@ -316,6 +316,8 @@
 	struct rec_timing timing[8];
 	u8 mincoarse;
 
+	printk(BIOS_DEBUG, "Starting DQS receiver enable calibration\n");
+
 	MCHBAR8(0x5d8) = MCHBAR8(0x5d8) & ~0xc;
 	MCHBAR8(0x9d8) = MCHBAR8(0x9d8) & ~0xc;
 	MCHBAR8(0x5dc) = MCHBAR8(0x5dc) & ~0x80;

-- 
To view, visit https://review.coreboot.org/22912
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ib568621e6d044624c1c0aeb6fb08945f561395c7
Gerrit-Change-Number: 22912
Gerrit-PatchSet: 1
Gerrit-Owner: Arthur Heymans <arthur at aheymans.xyz>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20171216/b035c4a7/attachment.html>


More information about the coreboot-gerrit mailing list