<p>Arthur Heymans has uploaded this change for <strong>review</strong>.</p><p><a href="https://review.coreboot.org/22912">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">nb/intel/x4x/rcven.c: Change the verbosity of some messages<br><br>Displaying the whole receive enable procedure should only be done if<br>CONFIG_DEBUG_RAM_SETUP is selected.<br><br>Change-Id: Ib568621e6d044624c1c0aeb6fb08945f561395c7<br>Signed-off-by: Arthur Heymans <arthur@aheymans.xyz><br>---<br>M src/northbridge/intel/x4x/rcven.c<br>1 file changed, 10 insertions(+), 8 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://review.coreboot.org:29418/coreboot refs/changes/12/22912/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">diff --git a/src/northbridge/intel/x4x/rcven.c b/src/northbridge/intel/x4x/rcven.c<br>index 4cd48df..c2b5ad6 100644<br>--- a/src/northbridge/intel/x4x/rcven.c<br>+++ b/src/northbridge/intel/x4x/rcven.c<br>@@ -138,7 +138,7 @@<br> static int decr_coarse_low(u8 channel, u8 lane, u32 addr,<br> struct rec_timing *timing)<br> {<br>- printk(BIOS_DEBUG,<br>+ printk(RAM_DEBUG,<br> " Decreasing coarse until high to low transition is found\n");<br> while (sampledqs(addr, lane, channel) != DQS_LOW) {<br> if (timing->coarse == 0) {<br>@@ -149,7 +149,7 @@<br> timing->coarse--;<br> program_timing(timing, channel, lane);<br> }<br>- printk(BIOS_DEBUG, " DQS low at coarse=%d medium=%d\n",<br>+ printk(RAM_DEBUG, " DQS low at coarse=%d medium=%d\n",<br> timing->coarse, timing->medium);<br> return 0;<br> }<br>@@ -157,7 +157,7 @@<br> static int fine_search_dqs_high(u8 channel, u8 lane, u32 addr,<br> struct rec_timing *timing)<br> {<br>- printk(BIOS_DEBUG,<br>+ printk(RAM_DEBUG,<br> " Increasing TAP until low to high transition is found\n");<br> /*<br> * We use a do while loop since it happens that the strobe read<br>@@ -184,7 +184,7 @@<br> program_timing(timing, channel, lane);<br> } while (sampledqs(addr, lane, channel) != DQS_HIGH);<br> <br>- printk(BIOS_DEBUG, " DQS high at coarse=%d medium=%d tap:%d\n",<br>+ printk(RAM_DEBUG, " DQS high at coarse=%d medium=%d tap:%d\n",<br> timing->coarse, timing->medium, timing->tap);<br> return 0;<br> }<br>@@ -193,7 +193,7 @@<br> struct rec_timing *timing)<br> {<br> /* Look for DQS low, using quarter steps. */<br>- printk(BIOS_DEBUG, " Increasing medium until DQS LOW is found\n");<br>+ printk(RAM_DEBUG, " Increasing medium until DQS LOW is found\n");<br> while (sampledqs(addr, lane, channel) != DQS_LOW) {<br> if (increase_medium(timing)) {<br> printk(BIOS_CRIT,<br>@@ -202,7 +202,7 @@<br> }<br> program_timing(timing, channel, lane);<br> }<br>- printk(BIOS_DEBUG, " DQS low at coarse=%d medium=%d\n",<br>+ printk(RAM_DEBUG, " DQS low at coarse=%d medium=%d\n",<br> timing->coarse, timing->medium);<br> return 0;<br> }<br>@@ -210,7 +210,7 @@<br> struct rec_timing *timing)<br> {<br> /* Look for DQS high, using quarter steps. */<br>- printk(BIOS_DEBUG, " Increasing medium until DQS HIGH is found\n");<br>+ printk(RAM_DEBUG, " Increasing medium until DQS HIGH is found\n");<br> while (sampledqs(addr, lane, channel) != DQS_HIGH) {<br> if (increase_medium(timing)) {<br> printk(BIOS_CRIT,<br>@@ -219,7 +219,7 @@<br> }<br> program_timing(timing, channel, lane);<br> }<br>- printk(BIOS_DEBUG, " DQS high at coarse=%d medium=%d\n",<br>+ printk(RAM_DEBUG, " DQS high at coarse=%d medium=%d\n",<br> timing->coarse, timing->medium);<br> return 0;<br> }<br>@@ -316,6 +316,8 @@<br> struct rec_timing timing[8];<br> u8 mincoarse;<br> <br>+ printk(BIOS_DEBUG, "Starting DQS receiver enable calibration\n");<br>+<br> MCHBAR8(0x5d8) = MCHBAR8(0x5d8) & ~0xc;<br> MCHBAR8(0x9d8) = MCHBAR8(0x9d8) & ~0xc;<br> MCHBAR8(0x5dc) = MCHBAR8(0x5dc) & ~0x80;<br></pre><p>To view, visit <a href="https://review.coreboot.org/22912">change 22912</a>. To unsubscribe, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/22912"/><meta itemprop="name" content="View Change"/></div></div>
<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>
<div style="display:none"> Gerrit-Change-Id: Ib568621e6d044624c1c0aeb6fb08945f561395c7 </div>
<div style="display:none"> Gerrit-Change-Number: 22912 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Arthur Heymans <arthur@aheymans.xyz> </div>