[coreboot-gerrit] Change in coreboot[master]: google/gru: Adjust to incorrect strapping resistors on Kevin

[David Schneider (Code Review)]

David Schneider has posted comments on this change. ( https://review.coreboot.org/22891 )

Change subject: google/gru: Adjust to incorrect strapping resistors on Kevin
......................................................................


Patch Set 2: Code-Review+1

> Patch Set 1:
> 
> (1 comment)
> 
> > Every other bucket is ~60 wide, with 30 on each side...except for bucket 1, which has 30 on the high side and 40 on the low side.
> 
> Yeah, but I still don't see the value in changing that. The buckets are skewed but that's the way they were designed. If I put a number in there that's not the arithmetic mean between the target points it's just going to confuse someone later. It's about documentation too... if I didn't split it up I'd still have to put a comment explaining that Kevin is special which takes up about the same amount of space. This is the easiest way to just represent that right in the code.

Okay, this way is fine, then.


-- 
To view, visit https://review.coreboot.org/22891
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic5199834fbeaf734e725ff45b04f45eefe149855
Gerrit-Change-Number: 22891
Gerrit-PatchSet: 2
Gerrit-Owner: Julius Werner <jwerner at chromium.org>
Gerrit-Reviewer: David Schneider <dnschneid at chromium.org>
Gerrit-Reviewer: Julius Werner <jwerner at chromium.org>
Gerrit-Reviewer: Lin Huang <hl at rock-chips.com>
Gerrit-Reviewer: Philip Chen <philipchen at chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-Comment-Date: Fri, 15 Dec 2017 03:54:08 +0000
Gerrit-HasComments: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20171215/0bec4635/attachment.html>