[coreboot-gerrit] Change in coreboot[master]: google/gru: Adjust to incorrect strapping resistors on Kevin

Julius Werner (Code Review) gerrit at coreboot.org
Fri Dec 15 04:43:49 CET 2017


Hello Lin Huang, David Schneider, Philip Chen, build bot (Jenkins), 

I'd like you to reexamine a change. Please visit

    https://review.coreboot.org/22891

to look at the new patch set (#2).

Change subject: google/gru: Adjust to incorrect strapping resistors on Kevin
......................................................................

google/gru: Adjust to incorrect strapping resistors on Kevin

It seems that RAM code 0 has been strapped with an incorrect resistor on
Kevin. The resulting voltage divide still puts it well within the ADC
value bucket reserved for that slot, but a little closer to the edge
than necessary. While this doesn't seem to cause any immediate problems
on its own, it still doesn't hurt to fix it (if only for the
documentation value).

On other boards (at least on my Scarlet) the strapping seems to be
correct.

Change-Id: Ic5199834fbeaf734e725ff45b04f45eefe149855
Signed-off-by: Julius Werner <jwerner at chromium.org>
---
M src/mainboard/google/gru/boardid.c
1 file changed, 4 insertions(+), 0 deletions(-)


  git pull ssh://review.coreboot.org:29418/coreboot refs/changes/91/22891/2
-- 
To view, visit https://review.coreboot.org/22891
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ic5199834fbeaf734e725ff45b04f45eefe149855
Gerrit-Change-Number: 22891
Gerrit-PatchSet: 2
Gerrit-Owner: Julius Werner <jwerner at chromium.org>
Gerrit-Reviewer: David Schneider <dnschneid at chromium.org>
Gerrit-Reviewer: Julius Werner <jwerner at chromium.org>
Gerrit-Reviewer: Lin Huang <hl at rock-chips.com>
Gerrit-Reviewer: Philip Chen <philipchen at chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20171215/02ee7904/attachment.html>


More information about the coreboot-gerrit mailing list