[coreboot-gerrit] Change in coreboot[master]: intel/dcp847ske: Enable RAM voltage setting

Tobias Diedrich (Code Review) gerrit at coreboot.org
Wed Dec 13 01:33:39 CET 2017


Tobias Diedrich has uploaded this change for review. ( https://review.coreboot.org/22836


Change subject: intel/dcp847ske: Enable RAM voltage setting
......................................................................

intel/dcp847ske: Enable RAM voltage setting

Use the hooks introduced in https://review.coreboot.org/#/c/22806/ to
enable setting the RAM voltage before RAM training.

Change-Id: Ib0e2b4e90b5eda2da14834f4721649fd77ec1025
Signed-off-by: Tobias Diedrich <ranma+coreboot at tdiedrich.de>
---
M src/mainboard/intel/dcp847ske/romstage.c
1 file changed, 18 insertions(+), 1 deletion(-)



  git pull ssh://review.coreboot.org:29418/coreboot refs/changes/36/22836/1

diff --git a/src/mainboard/intel/dcp847ske/romstage.c b/src/mainboard/intel/dcp847ske/romstage.c
index ad31bba..98bc6dd 100644
--- a/src/mainboard/intel/dcp847ske/romstage.c
+++ b/src/mainboard/intel/dcp847ske/romstage.c
@@ -16,7 +16,9 @@
  * GNU General Public License for more details.
  */
 
+#include <console/console.h>
 #include <stdint.h>
+#include <southbridge/intel/common/gpio.h>
 #include <northbridge/intel/sandybridge/sandybridge.h>
 #if IS_ENABLED(CONFIG_USE_NATIVE_RAMINIT)
 #include <northbridge/intel/sandybridge/raminit_native.h>
@@ -24,7 +26,22 @@
 #include <northbridge/intel/sandybridge/raminit.h>
 #endif
 
-#if !IS_ENABLED(CONFIG_USE_NATIVE_RAMINIT)
+#if IS_ENABLED(CONFIG_USE_NATIVE_RAMINIT)
+void mainboard_supported_dram_voltage(dimm_voltage_t *voltage)
+{
+	voltage->min_millivolts = 1350;
+	voltage->max_millivolts = 1500;
+}
+
+void mainboard_set_dram_voltage(const u16 voltage)
+{
+	if (voltage < 1500) {
+		// GPIO8 default from gpio.c is LOW (1.5V).
+		// Set to HIGH to lower ram voltage to 1.35V.
+		set_gpio(8, 1);
+	}
+}
+#else
 void mainboard_fill_pei_data(struct pei_data *pei_data)
 {
 	struct pei_data pei_data_template = {

-- 
To view, visit https://review.coreboot.org/22836
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ib0e2b4e90b5eda2da14834f4721649fd77ec1025
Gerrit-Change-Number: 22836
Gerrit-PatchSet: 1
Gerrit-Owner: Tobias Diedrich <ranma+coreboot at tdiedrich.de>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20171213/08197e77/attachment.html>


More information about the coreboot-gerrit mailing list