[coreboot-gerrit] Change in coreboot[master]: mainboard/{intel, google}: Make use of commom SMM code for mainboards

[Subrata Banik (Code Review)]

Hello Brandon Breitenstein,

I'd like you to do a code review. Please visit

    https://review.coreboot.org/22827

to review the following change.


Change subject: mainboard/{intel, google}: Make use of commom SMM code for mainboards
......................................................................

mainboard/{intel, google}: Make use of commom SMM code for mainboards

This patch ensures all skylake, kabylake mainboards are using
common SMM code.

Change-Id: I3001ce85268c2fa670c426d0dc706bff2dfdb4ed
Signed-off-by: Subrata Banik <subrata.banik at intel.com>
Signed-off-by: Brandon Breitenstein <brandon.breitenstein at intel.com>
---
M src/mainboard/google/chell/smihandler.c
M src/mainboard/google/eve/smihandler.c
M src/mainboard/google/fizz/smihandler.c
M src/mainboard/google/glados/smihandler.c
M src/mainboard/google/lars/smihandler.c
M src/mainboard/google/poppy/smihandler.c
M src/mainboard/intel/kblrvp/smihandler.c
M src/mainboard/intel/kunimitsu/smihandler.c
8 files changed, 8 insertions(+), 9 deletions(-)



  git pull ssh://review.coreboot.org:29418/coreboot refs/changes/27/22827/1

diff --git a/src/mainboard/google/chell/smihandler.c b/src/mainboard/google/chell/smihandler.c
index c831983..73e18d9 100644
--- a/src/mainboard/google/chell/smihandler.c
+++ b/src/mainboard/google/chell/smihandler.c
@@ -21,10 +21,10 @@
 #include <elog.h>
 #include <ec/google/chromeec/smm.h>
 #include <gpio.h>
+#include <intelblocks/smihandler.h>
 #include <soc/iomap.h>
 #include <soc/nvs.h>
 #include <soc/pm.h>
-#include <soc/smm.h>
 #include "ec.h"
 #include "gpio.h"
 
diff --git a/src/mainboard/google/eve/smihandler.c b/src/mainboard/google/eve/smihandler.c
index e449900..86a4fb3 100644
--- a/src/mainboard/google/eve/smihandler.c
+++ b/src/mainboard/google/eve/smihandler.c
@@ -17,9 +17,9 @@
 #include <cpu/x86/smm.h>
 #include <ec/google/chromeec/smm.h>
 #include <gpio.h>
-#include <soc/smm.h>
 #include "ec.h"
 #include "gpio.h"
+#include <intelblocks/smihandler.h>
 
 void mainboard_smi_espi_handler(void)
 {
diff --git a/src/mainboard/google/fizz/smihandler.c b/src/mainboard/google/fizz/smihandler.c
index 5f05b2e..dbf8c25 100644
--- a/src/mainboard/google/fizz/smihandler.c
+++ b/src/mainboard/google/fizz/smihandler.c
@@ -15,7 +15,7 @@
 
 #include <cpu/x86/smm.h>
 #include <ec/google/chromeec/smm.h>
-#include <soc/smm.h>
+#include <intelblocks/smihandler.h>
 
 #include "ec.h"
 
diff --git a/src/mainboard/google/glados/smihandler.c b/src/mainboard/google/glados/smihandler.c
index c831983..73e18d9 100644
--- a/src/mainboard/google/glados/smihandler.c
+++ b/src/mainboard/google/glados/smihandler.c
@@ -21,10 +21,10 @@
 #include <elog.h>
 #include <ec/google/chromeec/smm.h>
 #include <gpio.h>
+#include <intelblocks/smihandler.h>
 #include <soc/iomap.h>
 #include <soc/nvs.h>
 #include <soc/pm.h>
-#include <soc/smm.h>
 #include "ec.h"
 #include "gpio.h"
 
diff --git a/src/mainboard/google/lars/smihandler.c b/src/mainboard/google/lars/smihandler.c
index 24a5b96..cc8781b 100644
--- a/src/mainboard/google/lars/smihandler.c
+++ b/src/mainboard/google/lars/smihandler.c
@@ -20,10 +20,10 @@
 #include <cpu/x86/smm.h>
 #include <elog.h>
 #include <ec/google/chromeec/smm.h>
+#include <intelblocks/smihandler.h>
 #include <soc/iomap.h>
 #include <soc/nvs.h>
 #include <soc/pm.h>
-#include <soc/smm.h>
 #include "ec.h"
 #include "gpio.h"
 
diff --git a/src/mainboard/google/poppy/smihandler.c b/src/mainboard/google/poppy/smihandler.c
index e880581..55dd5f2 100644
--- a/src/mainboard/google/poppy/smihandler.c
+++ b/src/mainboard/google/poppy/smihandler.c
@@ -18,9 +18,8 @@
 #include <ec/google/chromeec/smm.h>
 #include <elog.h>
 #include <gpio.h>
+#include <intelblocks/smihandler.h>
 #include <soc/gpio.h>
-#include <soc/smm.h>
-
 #include <variant/gpio.h>
 #include <variant/ec.h>
 
diff --git a/src/mainboard/intel/kblrvp/smihandler.c b/src/mainboard/intel/kblrvp/smihandler.c
index 9ecc43a..7532732 100644
--- a/src/mainboard/intel/kblrvp/smihandler.c
+++ b/src/mainboard/intel/kblrvp/smihandler.c
@@ -20,10 +20,10 @@
 #include <cpu/x86/smm.h>
 #include <elog.h>
 #include <ec/google/chromeec/smm.h>
+#include <intelblocks/smihandler.h>
 #include <soc/iomap.h>
 #include <soc/nvs.h>
 #include <soc/pm.h>
-#include <soc/smm.h>
 #include "ec.h"
 #include <variant/gpio.h>
 
diff --git a/src/mainboard/intel/kunimitsu/smihandler.c b/src/mainboard/intel/kunimitsu/smihandler.c
index 24a5b96..cc8781b 100644
--- a/src/mainboard/intel/kunimitsu/smihandler.c
+++ b/src/mainboard/intel/kunimitsu/smihandler.c
@@ -20,10 +20,10 @@
 #include <cpu/x86/smm.h>
 #include <elog.h>
 #include <ec/google/chromeec/smm.h>
+#include <intelblocks/smihandler.h>
 #include <soc/iomap.h>
 #include <soc/nvs.h>
 #include <soc/pm.h>
-#include <soc/smm.h>
 #include "ec.h"
 #include "gpio.h"
 

-- 
To view, visit https://review.coreboot.org/22827
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I3001ce85268c2fa670c426d0dc706bff2dfdb4ed
Gerrit-Change-Number: 22827
Gerrit-PatchSet: 1
Gerrit-Owner: Subrata Banik <subrata.banik at intel.com>
Gerrit-Reviewer: Brandon Breitenstein <brandon.breitenstein at intel.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20171212/7c6b2f7c/attachment-0001.html>