<p>Subrata Banik would like Brandon Breitenstein to <strong>review</strong> this change.</p><p><a href="https://review.coreboot.org/22827">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">mainboard/{intel, google}: Make use of commom SMM code for mainboards<br><br>This patch ensures all skylake, kabylake mainboards are using<br>common SMM code.<br><br>Change-Id: I3001ce85268c2fa670c426d0dc706bff2dfdb4ed<br>Signed-off-by: Subrata Banik <subrata.banik@intel.com><br>Signed-off-by: Brandon Breitenstein <brandon.breitenstein@intel.com><br>---<br>M src/mainboard/google/chell/smihandler.c<br>M src/mainboard/google/eve/smihandler.c<br>M src/mainboard/google/fizz/smihandler.c<br>M src/mainboard/google/glados/smihandler.c<br>M src/mainboard/google/lars/smihandler.c<br>M src/mainboard/google/poppy/smihandler.c<br>M src/mainboard/intel/kblrvp/smihandler.c<br>M src/mainboard/intel/kunimitsu/smihandler.c<br>8 files changed, 8 insertions(+), 9 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://review.coreboot.org:29418/coreboot refs/changes/27/22827/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">diff --git a/src/mainboard/google/chell/smihandler.c b/src/mainboard/google/chell/smihandler.c<br>index c831983..73e18d9 100644<br>--- a/src/mainboard/google/chell/smihandler.c<br>+++ b/src/mainboard/google/chell/smihandler.c<br>@@ -21,10 +21,10 @@<br> #include <elog.h><br> #include <ec/google/chromeec/smm.h><br> #include <gpio.h><br>+#include <intelblocks/smihandler.h><br> #include <soc/iomap.h><br> #include <soc/nvs.h><br> #include <soc/pm.h><br>-#include <soc/smm.h><br> #include "ec.h"<br> #include "gpio.h"<br> <br>diff --git a/src/mainboard/google/eve/smihandler.c b/src/mainboard/google/eve/smihandler.c<br>index e449900..86a4fb3 100644<br>--- a/src/mainboard/google/eve/smihandler.c<br>+++ b/src/mainboard/google/eve/smihandler.c<br>@@ -17,9 +17,9 @@<br> #include <cpu/x86/smm.h><br> #include <ec/google/chromeec/smm.h><br> #include <gpio.h><br>-#include <soc/smm.h><br> #include "ec.h"<br> #include "gpio.h"<br>+#include <intelblocks/smihandler.h><br> <br> void mainboard_smi_espi_handler(void)<br> {<br>diff --git a/src/mainboard/google/fizz/smihandler.c b/src/mainboard/google/fizz/smihandler.c<br>index 5f05b2e..dbf8c25 100644<br>--- a/src/mainboard/google/fizz/smihandler.c<br>+++ b/src/mainboard/google/fizz/smihandler.c<br>@@ -15,7 +15,7 @@<br> <br> #include <cpu/x86/smm.h><br> #include <ec/google/chromeec/smm.h><br>-#include <soc/smm.h><br>+#include <intelblocks/smihandler.h><br> <br> #include "ec.h"<br> <br>diff --git a/src/mainboard/google/glados/smihandler.c b/src/mainboard/google/glados/smihandler.c<br>index c831983..73e18d9 100644<br>--- a/src/mainboard/google/glados/smihandler.c<br>+++ b/src/mainboard/google/glados/smihandler.c<br>@@ -21,10 +21,10 @@<br> #include <elog.h><br> #include <ec/google/chromeec/smm.h><br> #include <gpio.h><br>+#include <intelblocks/smihandler.h><br> #include <soc/iomap.h><br> #include <soc/nvs.h><br> #include <soc/pm.h><br>-#include <soc/smm.h><br> #include "ec.h"<br> #include "gpio.h"<br> <br>diff --git a/src/mainboard/google/lars/smihandler.c b/src/mainboard/google/lars/smihandler.c<br>index 24a5b96..cc8781b 100644<br>--- a/src/mainboard/google/lars/smihandler.c<br>+++ b/src/mainboard/google/lars/smihandler.c<br>@@ -20,10 +20,10 @@<br> #include <cpu/x86/smm.h><br> #include <elog.h><br> #include <ec/google/chromeec/smm.h><br>+#include <intelblocks/smihandler.h><br> #include <soc/iomap.h><br> #include <soc/nvs.h><br> #include <soc/pm.h><br>-#include <soc/smm.h><br> #include "ec.h"<br> #include "gpio.h"<br> <br>diff --git a/src/mainboard/google/poppy/smihandler.c b/src/mainboard/google/poppy/smihandler.c<br>index e880581..55dd5f2 100644<br>--- a/src/mainboard/google/poppy/smihandler.c<br>+++ b/src/mainboard/google/poppy/smihandler.c<br>@@ -18,9 +18,8 @@<br> #include <ec/google/chromeec/smm.h><br> #include <elog.h><br> #include <gpio.h><br>+#include <intelblocks/smihandler.h><br> #include <soc/gpio.h><br>-#include <soc/smm.h><br>-<br> #include <variant/gpio.h><br> #include <variant/ec.h><br> <br>diff --git a/src/mainboard/intel/kblrvp/smihandler.c b/src/mainboard/intel/kblrvp/smihandler.c<br>index 9ecc43a..7532732 100644<br>--- a/src/mainboard/intel/kblrvp/smihandler.c<br>+++ b/src/mainboard/intel/kblrvp/smihandler.c<br>@@ -20,10 +20,10 @@<br> #include <cpu/x86/smm.h><br> #include <elog.h><br> #include <ec/google/chromeec/smm.h><br>+#include <intelblocks/smihandler.h><br> #include <soc/iomap.h><br> #include <soc/nvs.h><br> #include <soc/pm.h><br>-#include <soc/smm.h><br> #include "ec.h"<br> #include <variant/gpio.h><br> <br>diff --git a/src/mainboard/intel/kunimitsu/smihandler.c b/src/mainboard/intel/kunimitsu/smihandler.c<br>index 24a5b96..cc8781b 100644<br>--- a/src/mainboard/intel/kunimitsu/smihandler.c<br>+++ b/src/mainboard/intel/kunimitsu/smihandler.c<br>@@ -20,10 +20,10 @@<br> #include <cpu/x86/smm.h><br> #include <elog.h><br> #include <ec/google/chromeec/smm.h><br>+#include <intelblocks/smihandler.h><br> #include <soc/iomap.h><br> #include <soc/nvs.h><br> #include <soc/pm.h><br>-#include <soc/smm.h><br> #include "ec.h"<br> #include "gpio.h"<br> <br></pre><p>To view, visit <a href="https://review.coreboot.org/22827">change 22827</a>. To unsubscribe, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/22827"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>
<div style="display:none"> Gerrit-Change-Id: I3001ce85268c2fa670c426d0dc706bff2dfdb4ed </div>
<div style="display:none"> Gerrit-Change-Number: 22827 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Subrata Banik <subrata.banik@intel.com> </div>
<div style="display:none"> Gerrit-Reviewer: Brandon Breitenstein <brandon.breitenstein@intel.com> </div>