[coreboot-gerrit] Change in coreboot[master]: nb/intel/x4x/rcven.c: Reset the DQS probe twice

[Arthur Heymans (Code Review)]

Arthur Heymans has uploaded this change for review. ( https://review.coreboot.org/22813


Change subject: nb/intel/x4x/rcven.c: Reset the DQS probe twice
......................................................................

nb/intel/x4x/rcven.c: Reset the DQS probe twice

Vendor does this too. This might increase the somewhat noisy results
it was creating.

Change-Id: Ia4ea38919a0154203f5595b7c92804ecb3cf04ae
Signed-off-by: Arthur Heymans <arthur at aheymans.xyz>
---
M src/northbridge/intel/x4x/rcven.c
1 file changed, 7 insertions(+), 1 deletion(-)



  git pull ssh://review.coreboot.org:29418/coreboot refs/changes/13/22813/1

diff --git a/src/northbridge/intel/x4x/rcven.c b/src/northbridge/intel/x4x/rcven.c
index 23f8d52..6c28f15 100644
--- a/src/northbridge/intel/x4x/rcven.c
+++ b/src/northbridge/intel/x4x/rcven.c
@@ -44,11 +44,17 @@
 	volatile u32 strobe;
 	u32 sample_offset = 0x400 * channel + 0x561 + lane * 4;
 
-	/* Reset the DQS probe */
+	/* Reset the DQS probe twice */
 	MCHBAR8(RESET_CNTL(channel)) &= ~0x2;
 	udelay(2);
 	MCHBAR8(RESET_CNTL(channel)) |= 0x2;
 	udelay(2);
+
+	MCHBAR8(RESET_CNTL(channel)) &= ~0x2;
+	udelay(2);
+	MCHBAR8(RESET_CNTL(channel)) |= 0x2;
+	udelay(2);
+
 	barrier();
 	strobe = read32((u32 *)addr);
 	barrier();

-- 
To view, visit https://review.coreboot.org/22813
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ia4ea38919a0154203f5595b7c92804ecb3cf04ae
Gerrit-Change-Number: 22813
Gerrit-PatchSet: 1
Gerrit-Owner: Arthur Heymans <arthur at aheymans.xyz>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20171211/d3d363fe/attachment.html>