<p>Arthur Heymans has uploaded this change for <strong>review</strong>.</p><p><a href="https://review.coreboot.org/22813">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">nb/intel/x4x/rcven.c: Reset the DQS probe twice<br><br>Vendor does this too. This might increase the somewhat noisy results<br>it was creating.<br><br>Change-Id: Ia4ea38919a0154203f5595b7c92804ecb3cf04ae<br>Signed-off-by: Arthur Heymans <arthur@aheymans.xyz><br>---<br>M src/northbridge/intel/x4x/rcven.c<br>1 file changed, 7 insertions(+), 1 deletion(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://review.coreboot.org:29418/coreboot refs/changes/13/22813/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">diff --git a/src/northbridge/intel/x4x/rcven.c b/src/northbridge/intel/x4x/rcven.c<br>index 23f8d52..6c28f15 100644<br>--- a/src/northbridge/intel/x4x/rcven.c<br>+++ b/src/northbridge/intel/x4x/rcven.c<br>@@ -44,11 +44,17 @@<br>  volatile u32 strobe;<br>  u32 sample_offset = 0x400 * channel + 0x561 + lane * 4;<br> <br>-   /* Reset the DQS probe */<br>+    /* Reset the DQS probe twice */<br>       MCHBAR8(RESET_CNTL(channel)) &= ~0x2;<br>     udelay(2);<br>    MCHBAR8(RESET_CNTL(channel)) |= 0x2;<br>  udelay(2);<br>+<br>+        MCHBAR8(RESET_CNTL(channel)) &= ~0x2;<br>+    udelay(2);<br>+   MCHBAR8(RESET_CNTL(channel)) |= 0x2;<br>+ udelay(2);<br>+<br>         barrier();<br>    strobe = read32((u32 *)addr);<br>         barrier();<br></pre><p>To view, visit <a href="https://review.coreboot.org/22813">change 22813</a>. To unsubscribe, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/22813"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>
<div style="display:none"> Gerrit-Change-Id: Ia4ea38919a0154203f5595b7c92804ecb3cf04ae </div>
<div style="display:none"> Gerrit-Change-Number: 22813 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Arthur Heymans <arthur@aheymans.xyz> </div>