[coreboot-gerrit] Change in coreboot[master]: [draft] sb/intel/common: Automatically generate ACPI PIRQ

[Arthur Heymans (Code Review)]

Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/22810 )

Change subject: [draft] sb/intel/common: Automatically generate ACPI PIRQ
......................................................................


Patch Set 1: Code-Review+1

(2 comments)

This is nice! a few small issues and nits though...

https://review.coreboot.org/#/c/22810/1/src/southbridge/intel/bd82x6x/acpi/default_irq_route.asl
File src/southbridge/intel/bd82x6x/acpi/default_irq_route.asl:

https://review.coreboot.org/#/c/22810/1/src/southbridge/intel/bd82x6x/acpi/default_irq_route.asl@7
PS1, Line 7:  * modify it under the terms of the GNU General Public License as
just drop the file?


https://review.coreboot.org/#/c/22810/1/src/southbridge/intel/bd82x6x/lpc.c
File src/southbridge/intel/bd82x6x/lpc.c:

https://review.coreboot.org/#/c/22810/1/src/southbridge/intel/bd82x6x/lpc.c@830
PS1, Line 830: slot < 20 || slot > 31 || pci_pin < 1 || pci_pin > 4
slot 2 fn 0 also has a pin A that is always router to linkA.



-- 
To view, visit https://review.coreboot.org/22810
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic6b8ce4a9db50211a9c26221ca10105c5a0829a0
Gerrit-Change-Number: 22810
Gerrit-PatchSet: 1
Gerrit-Owner: Tobias Diedrich <ranma+coreboot at tdiedrich.de>
Gerrit-Reviewer: Arthur Heymans <arthur at aheymans.xyz>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-Comment-Date: Sun, 10 Dec 2017 21:00:19 +0000
Gerrit-HasComments: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20171210/64205b3d/attachment.html>