<p>Arthur Heymans <strong>posted comments</strong> on this change.</p><p><a href="https://review.coreboot.org/22810">View Change</a></p><p>Patch set 1:<span style="border-radius: 3px; display: inline-block; margin: 0 2px; padding: 4px;background-color: #d4ffd4;">Code-Review +1</span></p><p style="white-space: pre-wrap; word-wrap: break-word;">This is nice! a few small issues and nits though...</p><p>(2 comments)</p><ul style="list-style: none; padding-left: 20px;"><li><p><a href="https://review.coreboot.org/#/c/22810/1/src/southbridge/intel/bd82x6x/acpi/default_irq_route.asl">File src/southbridge/intel/bd82x6x/acpi/default_irq_route.asl:</a></p><ul style="list-style: none; padding-left: 20px;"><li><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/22810/1/src/southbridge/intel/bd82x6x/acpi/default_irq_route.asl@7">Patch Set #1, Line 7:</a> <code style="font-family:monospace,monospace"> * modify it under the terms of the GNU General Public License as</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">just drop the file?</p></li></ul></li><li><p><a href="https://review.coreboot.org/#/c/22810/1/src/southbridge/intel/bd82x6x/lpc.c">File src/southbridge/intel/bd82x6x/lpc.c:</a></p><ul style="list-style: none; padding-left: 20px;"><li><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/22810/1/src/southbridge/intel/bd82x6x/lpc.c@830">Patch Set #1, Line 830:</a> <code style="font-family:monospace,monospace">slot < 20 || slot > 31 || pci_pin < 1 || pci_pin > 4</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">slot 2 fn 0 also has a pin A that is always router to linkA.</p></li></ul></li></ul><p>To view, visit <a href="https://review.coreboot.org/22810">change 22810</a>. To unsubscribe, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/22810"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: comment </div>
<div style="display:none"> Gerrit-Change-Id: Ic6b8ce4a9db50211a9c26221ca10105c5a0829a0 </div>
<div style="display:none"> Gerrit-Change-Number: 22810 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Tobias Diedrich <ranma+coreboot@tdiedrich.de> </div>
<div style="display:none"> Gerrit-Reviewer: Arthur Heymans <arthur@aheymans.xyz> </div>
<div style="display:none"> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> </div>
<div style="display:none"> Gerrit-Comment-Date: Sun, 10 Dec 2017 21:00:19 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>