[coreboot-gerrit] Change in coreboot[master]: intel/sandybridge: Add RAM voltage hooks

[Patrick Rudolph (Code Review)]

Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/22806 )

Change subject: intel/sandybridge: Add RAM voltage hooks
......................................................................


Patch Set 1:

(1 comment)

https://review.coreboot.org/#/c/22806/1/src/northbridge/intel/sandybridge/raminit_common.c
File src/northbridge/intel/sandybridge/raminit_common.c:

https://review.coreboot.org/#/c/22806/1/src/northbridge/intel/sandybridge/raminit_common.c@3371
PS1, Line 3371: void __attribute__((weak)) mainboard_set_dram_voltage(dimm_flags_t flags)
mainboard_set_dram_voltage(const size_t voltage)

where voltage is in units of mV to be compatible with XMP memory profiles that allows overvolting.
The raminit code has to select the voltage and mainboard will set the most suitable.
A future improvement would be a devicetree setting that lists supported dram voltages.



-- 
To view, visit https://review.coreboot.org/22806
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic714c0717a66089dad4423d4eca5a0a29b7af817
Gerrit-Change-Number: 22806
Gerrit-PatchSet: 1
Gerrit-Owner: Tobias Diedrich <ranma+coreboot at tdiedrich.de>
Gerrit-Reviewer: Patrick Rudolph <siro at das-labor.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-Comment-Date: Sun, 10 Dec 2017 18:49:39 +0000
Gerrit-HasComments: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20171210/f6b9455a/attachment.html>