<p>Patrick Rudolph <strong>posted comments</strong> on this change.</p><p><a href="https://review.coreboot.org/22806">View Change</a></p><p>Patch set 1:</p><p>(1 comment)</p><ul style="list-style: none; padding-left: 20px;"><li><p><a href="https://review.coreboot.org/#/c/22806/1/src/northbridge/intel/sandybridge/raminit_common.c">File src/northbridge/intel/sandybridge/raminit_common.c:</a></p><ul style="list-style: none; padding-left: 20px;"><li><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/22806/1/src/northbridge/intel/sandybridge/raminit_common.c@3371">Patch Set #1, Line 3371:</a> <code style="font-family:monospace,monospace">void __attribute__((weak)) mainboard_set_dram_voltage(dimm_flags_t flags)</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">mainboard_set_dram_voltage(const size_t voltage)</p><p style="white-space: pre-wrap; word-wrap: break-word;">where voltage is in units of mV to be compatible with XMP memory profiles that allows overvolting.<br>The raminit code has to select the voltage and mainboard will set the most suitable.<br>A future improvement would be a devicetree setting that lists supported dram voltages.</p></li></ul></li></ul><p>To view, visit <a href="https://review.coreboot.org/22806">change 22806</a>. To unsubscribe, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/22806"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: comment </div>
<div style="display:none"> Gerrit-Change-Id: Ic714c0717a66089dad4423d4eca5a0a29b7af817 </div>
<div style="display:none"> Gerrit-Change-Number: 22806 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Tobias Diedrich <ranma+coreboot@tdiedrich.de> </div>
<div style="display:none"> Gerrit-Reviewer: Patrick Rudolph <siro@das-labor.org> </div>
<div style="display:none"> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> </div>
<div style="display:none"> Gerrit-Comment-Date: Sun, 10 Dec 2017 18:49:39 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>