[coreboot-gerrit] Change in coreboot[master]: sb/intel/common: Add function to automatically generate ACPI PIRQ

[Tobias Diedrich (Code Review)]

Tobias Diedrich has posted comments on this change. ( https://review.coreboot.org/22803 )

Change subject: sb/intel/common: Add function to automatically generate ACPI PIRQ
......................................................................


Patch Set 3:

(3 comments)

https://review.coreboot.org/#/c/22803/3/src/southbridge/intel/common/acpi_pirq_gen.c
File src/southbridge/intel/common/acpi_pirq_gen.c:

https://review.coreboot.org/#/c/22803/3/src/southbridge/intel/common/acpi_pirq_gen.c@37
PS3, Line 37: dublicate 
Typo: duplicate (below as well)


https://review.coreboot.org/#/c/22803/3/src/southbridge/intel/common/acpi_pirq_gen.c@43
PS3, Line 43: }
            : 		
I'd suggest adding the acpigen here with a flag, so you can call this below instead of duplicating the loop twice, which seems error prone.


https://review.coreboot.org/#/c/22803/3/src/southbridge/intel/common/acpi_pirq_gen.c@83
PS3, Line 83: int_pin - 1
pin to pirq mapping should be looked up in the register settings, in case it was modified by the boards setup code.



-- 
To view, visit https://review.coreboot.org/22803
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2b5d68adabf0840162c6f295af8d10d8d3007a34
Gerrit-Change-Number: 22803
Gerrit-PatchSet: 3
Gerrit-Owner: Arthur Heymans <arthur at aheymans.xyz>
Gerrit-Reviewer: Tobias Diedrich <ranma+coreboot at tdiedrich.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-Comment-Date: Sun, 10 Dec 2017 16:01:12 +0000
Gerrit-HasComments: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20171210/59071a64/attachment.html>