<p>Tobias Diedrich <strong>posted comments</strong> on this change.</p><p><a href="https://review.coreboot.org/22803">View Change</a></p><p>Patch set 3:</p><p>(3 comments)</p><ul style="list-style: none; padding-left: 20px;"><li><p><a href="https://review.coreboot.org/#/c/22803/3/src/southbridge/intel/common/acpi_pirq_gen.c">File src/southbridge/intel/common/acpi_pirq_gen.c:</a></p><ul style="list-style: none; padding-left: 20px;"><li><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/22803/3/src/southbridge/intel/common/acpi_pirq_gen.c@37">Patch Set #3, Line 37:</a> <code style="font-family:monospace,monospace">dublicate </code></p><p style="white-space: pre-wrap; word-wrap: break-word;">Typo: duplicate (below as well)</p></li><li><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/22803/3/src/southbridge/intel/common/acpi_pirq_gen.c@43">Patch Set #3, Line 43:</a> </p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;"><pre style="font-family: monospace,monospace; white-space: pre-wrap;">}<br>         <br></pre></blockquote></p><p style="white-space: pre-wrap; word-wrap: break-word;">I'd suggest adding the acpigen here with a flag, so you can call this below instead of duplicating the loop twice, which seems error prone.</p></li><li><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/22803/3/src/southbridge/intel/common/acpi_pirq_gen.c@83">Patch Set #3, Line 83:</a> <code style="font-family:monospace,monospace">int_pin - 1</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">pin to pirq mapping should be looked up in the register settings, in case it was modified by the boards setup code.</p></li></ul></li></ul><p>To view, visit <a href="https://review.coreboot.org/22803">change 22803</a>. To unsubscribe, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/22803"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: comment </div>
<div style="display:none"> Gerrit-Change-Id: I2b5d68adabf0840162c6f295af8d10d8d3007a34 </div>
<div style="display:none"> Gerrit-Change-Number: 22803 </div>
<div style="display:none"> Gerrit-PatchSet: 3 </div>
<div style="display:none"> Gerrit-Owner: Arthur Heymans <arthur@aheymans.xyz> </div>
<div style="display:none"> Gerrit-Reviewer: Tobias Diedrich <ranma+coreboot@tdiedrich.de> </div>
<div style="display:none"> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> </div>
<div style="display:none"> Gerrit-Comment-Date: Sun, 10 Dec 2017 16:01:12 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>