[coreboot-gerrit] Change in coreboot[master]: google/scarlet: support INNOLUX P097PFG panel

[Lin Huang (Code Review)]

Lin Huang has posted comments on this change. ( https://review.coreboot.org/22780 )

Change subject: google/scarlet: support INNOLUX P097PFG panel
......................................................................


Patch Set 1:

(1 comment)

https://review.coreboot.org/#/c/22780/1/src/mainboard/google/gru/mainboard.c
File src/mainboard/google/gru/mainboard.c:

https://review.coreboot.org/#/c/22780/1/src/mainboard/google/gru/mainboard.c@568
PS1, Line 568: 		if (sku_id() == 6) {
> Let's make this a switch-case statement. I think according to the current p
So how to translate sku_id still do not have final decision, right?



-- 
To view, visit https://review.coreboot.org/22780
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I43fa5d859a9a529a84c58a953b37d03953ce648a
Gerrit-Change-Number: 22780
Gerrit-PatchSet: 1
Gerrit-Owner: Lin Huang <hl at rock-chips.com>
Gerrit-Reviewer: Brian Norris <briannorris at chromium.org>
Gerrit-Reviewer: Julius Werner <jwerner at chromium.org>
Gerrit-Reviewer: Lin Huang <hl at rock-chips.com>
Gerrit-Reviewer: Matthias Kaehlcke <mka at chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-Comment-Date: Fri, 08 Dec 2017 03:48:07 +0000
Gerrit-HasComments: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20171208/fde3a66f/attachment.html>