[coreboot-gerrit] Change in coreboot[master]: google/scarlet: support INNOLUX P097PFG panel

[Julius Werner (Code Review)]

Julius Werner has posted comments on this change. ( https://review.coreboot.org/22780 )

Change subject: google/scarlet: support INNOLUX P097PFG panel
......................................................................


Patch Set 1:

(2 comments)

https://review.coreboot.org/#/c/22780/1/src/mainboard/google/gru/mainboard.c
File src/mainboard/google/gru/mainboard.c:

https://review.coreboot.org/#/c/22780/1/src/mainboard/google/gru/mainboard.c@567
PS1, Line 567: 	if (IS_ENABLED(CONFIG_GRU_BASEBOARD_SCARLET)) {
Let's not add this until we have other boards that need different panels.


https://review.coreboot.org/#/c/22780/1/src/mainboard/google/gru/mainboard.c@568
PS1, Line 568: 		if (sku_id() == 6) {
Let's make this a switch-case statement. I think according to the current plan only SKU pin 0 decides the panel, and the others are reserved for non-panel components (at least for now). So this should be:

 switch (sku_id()) {
   case 0:
   case 2:
   case 4:
   case 6:
      ...innolux...
   case 1:
   case 3:
   case 5:
   case 7:
     ...king...
 }

(Although Brian just told me that apparently our SKU pins don't read the way we expected them to, so that might still change once we figure out what's going on.)



-- 
To view, visit https://review.coreboot.org/22780
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I43fa5d859a9a529a84c58a953b37d03953ce648a
Gerrit-Change-Number: 22780
Gerrit-PatchSet: 1
Gerrit-Owner: Lin Huang <hl at rock-chips.com>
Gerrit-Reviewer: Brian Norris <briannorris at chromium.org>
Gerrit-Reviewer: Julius Werner <jwerner at chromium.org>
Gerrit-Reviewer: Matthias Kaehlcke <mka at chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-Comment-Date: Fri, 08 Dec 2017 03:29:38 +0000
Gerrit-HasComments: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20171208/5064c26d/attachment.html>