[coreboot-gerrit] Change in coreboot[master]: mb/google/poppy, nautilus, soraka: Disable PD on AC_PRESENT in deep Sx

Furquan Shaikh (Code Review) gerrit at coreboot.org
Mon Dec 4 06:56:23 CET 2017


Furquan Shaikh has uploaded this change for review. ( https://review.coreboot.org/22689


Change subject: mb/google/poppy,nautilus,soraka: Disable PD on AC_PRESENT in deep Sx
......................................................................

mb/google/poppy,nautilus,soraka: Disable PD on AC_PRESENT in deep Sx

This change updates device tree deep_sx_config to disable internal
pull-down on AC_PRESENT.

Change-Id: I041900a5262f8fd920856f126185329242a0639a
Signed-off-by: Furquan Shaikh <furquan at chromium.org>
---
M src/mainboard/google/poppy/variants/baseboard/devicetree.cb
M src/mainboard/google/poppy/variants/nautilus/devicetree.cb
M src/mainboard/google/poppy/variants/soraka/devicetree.cb
3 files changed, 3 insertions(+), 3 deletions(-)



  git pull ssh://review.coreboot.org:29418/coreboot refs/changes/89/22689/1

diff --git a/src/mainboard/google/poppy/variants/baseboard/devicetree.cb b/src/mainboard/google/poppy/variants/baseboard/devicetree.cb
index 920ab5c..232aea5 100644
--- a/src/mainboard/google/poppy/variants/baseboard/devicetree.cb
+++ b/src/mainboard/google/poppy/variants/baseboard/devicetree.cb
@@ -5,7 +5,7 @@
 	register "deep_s3_enable_dc" = "0"
 	register "deep_s5_enable_ac" = "1"
 	register "deep_s5_enable_dc" = "1"
-	register "deep_sx_config" = "DSX_EN_LAN_WAKE_PIN | DSX_EN_WAKE_PIN"
+	register "deep_sx_config" = "DSX_EN_LAN_WAKE_PIN | DSX_EN_WAKE_PIN | DSX_DIS_AC_PRESENT_PD"
 
 	# GPE configuration
 	# Note that GPE events called out in ASL code rely on this
diff --git a/src/mainboard/google/poppy/variants/nautilus/devicetree.cb b/src/mainboard/google/poppy/variants/nautilus/devicetree.cb
index fe11a2e..771bd72 100644
--- a/src/mainboard/google/poppy/variants/nautilus/devicetree.cb
+++ b/src/mainboard/google/poppy/variants/nautilus/devicetree.cb
@@ -5,7 +5,7 @@
 	register "deep_s3_enable_dc" = "0"
 	register "deep_s5_enable_ac" = "1"
 	register "deep_s5_enable_dc" = "1"
-	register "deep_sx_config" = "DSX_EN_LAN_WAKE_PIN | DSX_EN_WAKE_PIN"
+	register "deep_sx_config" = "DSX_EN_LAN_WAKE_PIN | DSX_EN_WAKE_PIN | DSX_DIS_AC_PRESENT_PD"
 
 	# GPE configuration
 	# Note that GPE events called out in ASL code rely on this
diff --git a/src/mainboard/google/poppy/variants/soraka/devicetree.cb b/src/mainboard/google/poppy/variants/soraka/devicetree.cb
index db3f2a2..5e5a537 100644
--- a/src/mainboard/google/poppy/variants/soraka/devicetree.cb
+++ b/src/mainboard/google/poppy/variants/soraka/devicetree.cb
@@ -5,7 +5,7 @@
 	register "deep_s3_enable_dc" = "0"
 	register "deep_s5_enable_ac" = "1"
 	register "deep_s5_enable_dc" = "1"
-	register "deep_sx_config" = "DSX_EN_LAN_WAKE_PIN | DSX_EN_WAKE_PIN"
+	register "deep_sx_config" = "DSX_EN_LAN_WAKE_PIN | DSX_EN_WAKE_PIN | DSX_DIS_AC_PRESENT_PD"
 
 	# GPE configuration
 	# Note that GPE events called out in ASL code rely on this

-- 
To view, visit https://review.coreboot.org/22689
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I041900a5262f8fd920856f126185329242a0639a
Gerrit-Change-Number: 22689
Gerrit-PatchSet: 1
Gerrit-Owner: Furquan Shaikh <furquan at google.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20171204/b45733fb/attachment-0001.html>


More information about the coreboot-gerrit mailing list