<p>Furquan Shaikh has uploaded this change for <strong>review</strong>.</p><p><a href="https://review.coreboot.org/22689">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">mb/google/poppy,nautilus,soraka: Disable PD on AC_PRESENT in deep Sx<br><br>This change updates device tree deep_sx_config to disable internal<br>pull-down on AC_PRESENT.<br><br>Change-Id: I041900a5262f8fd920856f126185329242a0639a<br>Signed-off-by: Furquan Shaikh <furquan@chromium.org><br>---<br>M src/mainboard/google/poppy/variants/baseboard/devicetree.cb<br>M src/mainboard/google/poppy/variants/nautilus/devicetree.cb<br>M src/mainboard/google/poppy/variants/soraka/devicetree.cb<br>3 files changed, 3 insertions(+), 3 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://review.coreboot.org:29418/coreboot refs/changes/89/22689/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">diff --git a/src/mainboard/google/poppy/variants/baseboard/devicetree.cb b/src/mainboard/google/poppy/variants/baseboard/devicetree.cb<br>index 920ab5c..232aea5 100644<br>--- a/src/mainboard/google/poppy/variants/baseboard/devicetree.cb<br>+++ b/src/mainboard/google/poppy/variants/baseboard/devicetree.cb<br>@@ -5,7 +5,7 @@<br>    register "deep_s3_enable_dc" = "0"<br>        register "deep_s5_enable_ac" = "1"<br>        register "deep_s5_enable_dc" = "1"<br>-       register "deep_sx_config" = "DSX_EN_LAN_WAKE_PIN | DSX_EN_WAKE_PIN"<br>+      register "deep_sx_config" = "DSX_EN_LAN_WAKE_PIN | DSX_EN_WAKE_PIN | DSX_DIS_AC_PRESENT_PD"<br> <br>    # GPE configuration<br>   # Note that GPE events called out in ASL code rely on this<br>diff --git a/src/mainboard/google/poppy/variants/nautilus/devicetree.cb b/src/mainboard/google/poppy/variants/nautilus/devicetree.cb<br>index fe11a2e..771bd72 100644<br>--- a/src/mainboard/google/poppy/variants/nautilus/devicetree.cb<br>+++ b/src/mainboard/google/poppy/variants/nautilus/devicetree.cb<br>@@ -5,7 +5,7 @@<br>  register "deep_s3_enable_dc" = "0"<br>        register "deep_s5_enable_ac" = "1"<br>        register "deep_s5_enable_dc" = "1"<br>-       register "deep_sx_config" = "DSX_EN_LAN_WAKE_PIN | DSX_EN_WAKE_PIN"<br>+      register "deep_sx_config" = "DSX_EN_LAN_WAKE_PIN | DSX_EN_WAKE_PIN | DSX_DIS_AC_PRESENT_PD"<br> <br>    # GPE configuration<br>   # Note that GPE events called out in ASL code rely on this<br>diff --git a/src/mainboard/google/poppy/variants/soraka/devicetree.cb b/src/mainboard/google/poppy/variants/soraka/devicetree.cb<br>index db3f2a2..5e5a537 100644<br>--- a/src/mainboard/google/poppy/variants/soraka/devicetree.cb<br>+++ b/src/mainboard/google/poppy/variants/soraka/devicetree.cb<br>@@ -5,7 +5,7 @@<br>  register "deep_s3_enable_dc" = "0"<br>        register "deep_s5_enable_ac" = "1"<br>        register "deep_s5_enable_dc" = "1"<br>-       register "deep_sx_config" = "DSX_EN_LAN_WAKE_PIN | DSX_EN_WAKE_PIN"<br>+      register "deep_sx_config" = "DSX_EN_LAN_WAKE_PIN | DSX_EN_WAKE_PIN | DSX_DIS_AC_PRESENT_PD"<br> <br>    # GPE configuration<br>   # Note that GPE events called out in ASL code rely on this<br></pre><p>To view, visit <a href="https://review.coreboot.org/22689">change 22689</a>. To unsubscribe, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/22689"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>
<div style="display:none"> Gerrit-Change-Id: I041900a5262f8fd920856f126185329242a0639a </div>
<div style="display:none"> Gerrit-Change-Number: 22689 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Furquan Shaikh <furquan@google.com> </div>