[coreboot-gerrit] Change in coreboot[master]: google/kahlee: Set USB OC pins

[Martin Roth (Code Review)]

Martin Roth has posted comments on this change. ( https://review.coreboot.org/22679 )

Change subject: google/kahlee: Set USB OC pins
......................................................................


Patch Set 1:

(2 comments)

https://review.coreboot.org/#/c/22679/1/src/mainboard/google/kahlee/variants/baseboard/gpio.c
File src/mainboard/google/kahlee/variants/baseboard/gpio.c:

https://review.coreboot.org/#/c/22679/1/src/mainboard/google/kahlee/variants/baseboard/gpio.c@50
PS1, Line 50: 	return 0;
Do we need to add something to disable the other 2?

 *map |= USB_OC_DISABLE << OC_PORT2_SHIFT;
 *map |= USB_OC_DISABLE << OC_PORT3_SHIFT;


https://review.coreboot.org/#/c/22679/1/src/mainboard/google/kahlee/variants/kahlee/gpio.c
File src/mainboard/google/kahlee/variants/kahlee/gpio.c:

https://review.coreboot.org/#/c/22679/1/src/mainboard/google/kahlee/variants/kahlee/gpio.c@155
PS1, Line 155: *map &= ~(USB_OC_DISABLE << OC_PORT0_SHIFT);
wouldn't it be cleaner just to disable ports 2 & 3?



-- 
To view, visit https://review.coreboot.org/22679
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I5a9b3409d9c91b89fd02f8eecf9e04c435f14342
Gerrit-Change-Number: 22679
Gerrit-PatchSet: 1
Gerrit-Owner: Marc Jones <marc at marcjonesconsulting.com>
Gerrit-Reviewer: Marc Jones <marc at marcjonesconsulting.com>
Gerrit-Reviewer: Martin Roth <martinroth at google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-Comment-Date: Sat, 02 Dec 2017 05:42:35 +0000
Gerrit-HasComments: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20171202/9dc10715/attachment.html>