<p>Martin Roth <strong>posted comments</strong> on this change.</p><p><a href="https://review.coreboot.org/22679">View Change</a></p><p>Patch set 1:</p><p>(2 comments)</p><ul style="list-style: none; padding-left: 20px;"><li><p><a href="https://review.coreboot.org/#/c/22679/1/src/mainboard/google/kahlee/variants/baseboard/gpio.c">File src/mainboard/google/kahlee/variants/baseboard/gpio.c:</a></p><ul style="list-style: none; padding-left: 20px;"><li><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/22679/1/src/mainboard/google/kahlee/variants/baseboard/gpio.c@50">Patch Set #1, Line 50:</a> <code style="font-family:monospace,monospace">  return 0;</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">Do we need to add something to disable the other 2?</p><pre style="font-family: monospace,monospace; white-space: pre-wrap;"> *map |= USB_OC_DISABLE << OC_PORT2_SHIFT;<br> *map |= USB_OC_DISABLE << OC_PORT3_SHIFT;</pre></li></ul></li><li><p><a href="https://review.coreboot.org/#/c/22679/1/src/mainboard/google/kahlee/variants/kahlee/gpio.c">File src/mainboard/google/kahlee/variants/kahlee/gpio.c:</a></p><ul style="list-style: none; padding-left: 20px;"><li><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/22679/1/src/mainboard/google/kahlee/variants/kahlee/gpio.c@155">Patch Set #1, Line 155:</a> <code style="font-family:monospace,monospace">*map &= ~(USB_OC_DISABLE << OC_PORT0_SHIFT);</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">wouldn't it be cleaner just to disable ports 2 & 3?</p></li></ul></li></ul><p>To view, visit <a href="https://review.coreboot.org/22679">change 22679</a>. To unsubscribe, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/22679"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: comment </div>
<div style="display:none"> Gerrit-Change-Id: I5a9b3409d9c91b89fd02f8eecf9e04c435f14342 </div>
<div style="display:none"> Gerrit-Change-Number: 22679 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Marc Jones <marc@marcjonesconsulting.com> </div>
<div style="display:none"> Gerrit-Reviewer: Marc Jones <marc@marcjonesconsulting.com> </div>
<div style="display:none"> Gerrit-Reviewer: Martin Roth <martinroth@google.com> </div>
<div style="display:none"> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> </div>
<div style="display:none"> Gerrit-Comment-Date: Sat, 02 Dec 2017 05:42:35 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>