[coreboot-gerrit] Change in coreboot[master]: nb/intel/pineview: Enable dram remapping.

Arthur Heymans (Code Review) gerrit at coreboot.org
Sun Aug 27 18:50:28 CEST 2017


Arthur Heymans has uploaded this change for review. ( https://review.coreboot.org/21228


Change subject: nb/intel/pineview: Enable dram remapping.
......................................................................

nb/intel/pineview: Enable dram remapping.

Without this remapping code enabled, the system fails to boot properly
if the amount of ram inserted is larger than 4G minus the mmio
space (hardcoded to 1G here).

Change-Id: I02e7ceed0cd9db7eb7182481b6989f80cef31ee5
Signed-off-by: Arthur Heymans <arthur at aheymans.xyz>
---
M src/northbridge/intel/pineview/raminit.c
1 file changed, 3 insertions(+), 1 deletion(-)



  git pull ssh://review.coreboot.org:29418/coreboot refs/changes/28/21228/1

diff --git a/src/northbridge/intel/pineview/raminit.c b/src/northbridge/intel/pineview/raminit.c
index 9bb8fd8..17cafec 100644
--- a/src/northbridge/intel/pineview/raminit.c
+++ b/src/northbridge/intel/pineview/raminit.c
@@ -2046,14 +2046,16 @@
 	reclaim = false;
 	tolud = MIN(0x1000 - mmiosize, tom);
 	if ((tom - tolud) > 0x40) {
-	//	reclaim = true;
+		reclaim = true;
 	}
+
 	if (reclaim) {
 		tolud = tolud & ~0x3f;
 		tom = tom & ~0x3f;
 		reclaimbase = MAX(0x1000, tom);
 		reclaimlimit = reclaimbase + (MIN(0x1000, tom) - tolud) - 0x40;
 	}
+
 	touud = tom;
 	if (reclaim) {
 		touud = reclaimlimit + 0x40;

-- 
To view, visit https://review.coreboot.org/21228
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I02e7ceed0cd9db7eb7182481b6989f80cef31ee5
Gerrit-Change-Number: 21228
Gerrit-PatchSet: 1
Gerrit-Owner: Arthur Heymans <arthur at aheymans.xyz>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20170827/9606556a/attachment.html>


More information about the coreboot-gerrit mailing list