<p>Arthur Heymans has uploaded this change for <strong>review</strong>.</p><p><a href="https://review.coreboot.org/21228">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">nb/intel/pineview: Enable dram remapping.<br><br>Without this remapping code enabled, the system fails to boot properly<br>if the amount of ram inserted is larger than 4G minus the mmio<br>space (hardcoded to 1G here).<br><br>Change-Id: I02e7ceed0cd9db7eb7182481b6989f80cef31ee5<br>Signed-off-by: Arthur Heymans <arthur@aheymans.xyz><br>---<br>M src/northbridge/intel/pineview/raminit.c<br>1 file changed, 3 insertions(+), 1 deletion(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://review.coreboot.org:29418/coreboot refs/changes/28/21228/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">diff --git a/src/northbridge/intel/pineview/raminit.c b/src/northbridge/intel/pineview/raminit.c<br>index 9bb8fd8..17cafec 100644<br>--- a/src/northbridge/intel/pineview/raminit.c<br>+++ b/src/northbridge/intel/pineview/raminit.c<br>@@ -2046,14 +2046,16 @@<br>  reclaim = false;<br>      tolud = MIN(0x1000 - mmiosize, tom);<br>  if ((tom - tolud) > 0x40) {<br>-       //      reclaim = true;<br>+              reclaim = true;<br>       }<br>+<br>  if (reclaim) {<br>                tolud = tolud & ~0x3f;<br>            tom = tom & ~0x3f;<br>                reclaimbase = MAX(0x1000, tom);<br>               reclaimlimit = reclaimbase + (MIN(0x1000, tom) - tolud) - 0x40;<br>       }<br>+<br>  touud = tom;<br>  if (reclaim) {<br>                touud = reclaimlimit + 0x40;<br></pre><p>To view, visit <a href="https://review.coreboot.org/21228">change 21228</a>. To unsubscribe, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/21228"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>
<div style="display:none"> Gerrit-Change-Id: I02e7ceed0cd9db7eb7182481b6989f80cef31ee5 </div>
<div style="display:none"> Gerrit-Change-Number: 21228 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Arthur Heymans <arthur@aheymans.xyz> </div>