[coreboot-gerrit] Change in coreboot[master]: amd/sb/sb700: Allocate wide LPC I/O devices where possible

[Arthur Heymans (Code Review)]

Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/21217 )

Change subject: amd/sb/sb700: Allocate wide LPC I/O devices where possible
......................................................................


Patch Set 1: Code-Review+2

(2 comments)

Patch looks fine but indentation levels could be reduced/improved so that's easier to read on smaller screens. Can happen in a follow up patch ofc.

https://review.coreboot.org/#/c/21217/1/src/southbridge/amd/sb700/lpc.c
File src/southbridge/amd/sb700/lpc.c:

https://review.coreboot.org/#/c/21217/1/src/southbridge/amd/sb700/lpc.c@a166
PS1, Line 166: 
             : 
Could the indentation be reduced by simply doing "continue" on the opposite of this conditional?


https://review.coreboot.org/#/c/21217/1/src/southbridge/amd/sb700/lpc.c@222
PS1, Line 222: 			"I/O window exhaustion\n", __func__, dev_path(child), base, end);
could this have a few tabs less so it fits the screen more easily?



-- 
To view, visit https://review.coreboot.org/21217
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I004bd0be31c91b76ae2a5e72690b44dca2fd9297
Gerrit-Change-Number: 21217
Gerrit-PatchSet: 1
Gerrit-Owner: Timothy Pearson <tpearson at raptorengineering.com>
Gerrit-Reviewer: Arthur Heymans <arthur at aheymans.xyz>
Gerrit-Reviewer: Martin Roth <martinroth at google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-Comment-Date: Sun, 27 Aug 2017 06:58:55 +0000
Gerrit-HasComments: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20170827/3219e101/attachment.html>