<p>Arthur Heymans <strong>posted comments</strong> on this change.</p><p><a href="https://review.coreboot.org/21217">View Change</a></p><p>Patch set 1:<span style="border-radius: 3px; display: inline-block; margin: 0 2px; padding: 4px;background-color: #d4ffd4;">Code-Review +2</span></p><p style="white-space: pre-wrap; word-wrap: break-word;">Patch looks fine but indentation levels could be reduced/improved so that's easier to read on smaller screens. Can happen in a follow up patch ofc.</p><p>(2 comments)</p><ul style="list-style: none; padding-left: 20px;"><li><p><a href="https://review.coreboot.org/#/c/21217/1/src/southbridge/amd/sb700/lpc.c">File src/southbridge/amd/sb700/lpc.c:</a></p><ul style="list-style: none; padding-left: 20px;"><li><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/21217/1/src/southbridge/amd/sb700/lpc.c@a166">Patch Set #1, Line 166:</a> </p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;"><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><br><br></pre></blockquote></p><p style="white-space: pre-wrap; word-wrap: break-word;">Could the indentation be reduced by simply doing "continue" on the opposite of this conditional?</p></li><li><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/21217/1/src/southbridge/amd/sb700/lpc.c@222">Patch Set #1, Line 222:</a> <code style="font-family:monospace,monospace">                        "I/O window exhaustion\n", __func__, dev_path(child), base, end);</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">could this have a few tabs less so it fits the screen more easily?</p></li></ul></li></ul><p>To view, visit <a href="https://review.coreboot.org/21217">change 21217</a>. To unsubscribe, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/21217"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: comment </div>
<div style="display:none"> Gerrit-Change-Id: I004bd0be31c91b76ae2a5e72690b44dca2fd9297 </div>
<div style="display:none"> Gerrit-Change-Number: 21217 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Timothy Pearson <tpearson@raptorengineering.com> </div>
<div style="display:none"> Gerrit-Reviewer: Arthur Heymans <arthur@aheymans.xyz> </div>
<div style="display:none"> Gerrit-Reviewer: Martin Roth <martinroth@google.com> </div>
<div style="display:none"> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> </div>
<div style="display:none"> Gerrit-Comment-Date: Sun, 27 Aug 2017 06:58:55 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>