[coreboot-gerrit] Change in coreboot[master]: nb/intel/i440bx/debug.c: Bugfix and cleanup

[Keith Hui (Code Review)]

Keith Hui has uploaded this change for review. ( https://review.coreboot.org/21203


Change subject: nb/intel/i440bx/debug.c: Bugfix and cleanup
......................................................................

nb/intel/i440bx/debug.c: Bugfix and cleanup

Fix dump_pci_device() broken in commit 65b72ab5 (Drop print_ implementation
from non-romcc boards) in 2015 (!) where only one in 16 bytes were being
dumped.

Also remove the #if redundant after commit aef8542 (Compile debug.c only if
CONFIG_DEBUG_RAM_SETUP) as this whole file is only compiled in that case.

Change-Id: I60e272b29417039feb15540e49d7300f86e5ed21
Signed-off-by: Keith Hui <buurin at gmail.com>
---
M src/northbridge/intel/i440bx/debug.c
1 file changed, 2 insertions(+), 3 deletions(-)



  git pull ssh://review.coreboot.org:29418/coreboot refs/changes/03/21203/1

diff --git a/src/northbridge/intel/i440bx/debug.c b/src/northbridge/intel/i440bx/debug.c
index c69725b..a1822e1 100644
--- a/src/northbridge/intel/i440bx/debug.c
+++ b/src/northbridge/intel/i440bx/debug.c
@@ -5,7 +5,6 @@
 #include <spd.h>
 #include <console/console.h>
 
-#if IS_ENABLED(CONFIG_DEBUG_RAM_SETUP)
 void dump_spd_registers(void)
 {
 	int i;
@@ -44,9 +43,9 @@
 		unsigned char val;
 		val = pci_read_config8(dev, i);
 		if ((i & 0x0f) == 0)
-			printk(BIOS_DEBUG, "%02x: %02x", i, val);
+			printk(BIOS_DEBUG, "%02x:", i);
+		printk(BIOS_DEBUG, " %02x", val);
 		if ((i & 0x0f) == 0x0f)
 			printk(BIOS_DEBUG, "\n");
 	}
 }
-#endif

-- 
To view, visit https://review.coreboot.org/21203
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I60e272b29417039feb15540e49d7300f86e5ed21
Gerrit-Change-Number: 21203
Gerrit-PatchSet: 1
Gerrit-Owner: Keith Hui <buurin at gmail.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20170825/673fdb4f/attachment.html>