<p>Keith Hui has uploaded this change for <strong>review</strong>.</p><p><a href="https://review.coreboot.org/21203">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">nb/intel/i440bx/debug.c: Bugfix and cleanup<br><br>Fix dump_pci_device() broken in commit 65b72ab5 (Drop print_ implementation<br>from non-romcc boards) in 2015 (!) where only one in 16 bytes were being<br>dumped.<br><br>Also remove the #if redundant after commit aef8542 (Compile debug.c only if<br>CONFIG_DEBUG_RAM_SETUP) as this whole file is only compiled in that case.<br><br>Change-Id: I60e272b29417039feb15540e49d7300f86e5ed21<br>Signed-off-by: Keith Hui <buurin@gmail.com><br>---<br>M src/northbridge/intel/i440bx/debug.c<br>1 file changed, 2 insertions(+), 3 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://review.coreboot.org:29418/coreboot refs/changes/03/21203/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">diff --git a/src/northbridge/intel/i440bx/debug.c b/src/northbridge/intel/i440bx/debug.c<br>index c69725b..a1822e1 100644<br>--- a/src/northbridge/intel/i440bx/debug.c<br>+++ b/src/northbridge/intel/i440bx/debug.c<br>@@ -5,7 +5,6 @@<br> #include <spd.h><br> #include <console/console.h><br> <br>-#if IS_ENABLED(CONFIG_DEBUG_RAM_SETUP)<br> void dump_spd_registers(void)<br> {<br>       int i;<br>@@ -44,9 +43,9 @@<br>             unsigned char val;<br>            val = pci_read_config8(dev, i);<br>               if ((i & 0x0f) == 0)<br>-                     printk(BIOS_DEBUG, "%02x: %02x", i, val);<br>+                  printk(BIOS_DEBUG, "%02x:", i);<br>+            printk(BIOS_DEBUG, " %02x", val);<br>           if ((i & 0x0f) == 0x0f)<br>                   printk(BIOS_DEBUG, "\n");<br>   }<br> }<br>-#endif<br></pre><p>To view, visit <a href="https://review.coreboot.org/21203">change 21203</a>. To unsubscribe, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/21203"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>
<div style="display:none"> Gerrit-Change-Id: I60e272b29417039feb15540e49d7300f86e5ed21 </div>
<div style="display:none"> Gerrit-Change-Number: 21203 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Keith Hui <buurin@gmail.com> </div>