[coreboot-gerrit] Change in coreboot[master]: sb/intel/bd82x6x: make hotplug map consistent to remapped ports

[Nico Huber (Code Review)]

Nico Huber has posted comments on this change. ( https://review.coreboot.org/21178 )

Change subject: sb/intel/bd82x6x: make hotplug map consistent to remapped ports
......................................................................


Patch Set 4:

(2 comments)

https://review.coreboot.org/#/c/21178/4/src/southbridge/intel/bd82x6x/pch.c
File src/southbridge/intel/bd82x6x/pch.c:

https://review.coreboot.org/#/c/21178/4/src/southbridge/intel/bd82x6x/pch.c@312
PS4, Line 312: old_hotplug_map
Using `config->pcie_hotplug_map` here instead would make it more
clear, IMHO (e.g. you don't need the implicit information where
`old_hotplug_map` points to, to see what is going on).

(The comment doesn't help to see that either.)


https://review.coreboot.org/#/c/21178/4/src/southbridge/intel/bd82x6x/pch.c@419
PS4, Line 419: 			pch_pcie_devicetree_update();
If you pass `config` here, you can probably drop all the if's above.



-- 
To view, visit https://review.coreboot.org/21178
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I28c4eaf82fb52fe793dfa2f824f14686b80951ad
Gerrit-Change-Number: 21178
Gerrit-PatchSet: 4
Gerrit-Owner: Bill XIE <persmule at gmail.com>
Gerrit-Reviewer: Arthur Heymans <arthur at aheymans.xyz>
Gerrit-Reviewer: Bill XIE <persmule at gmail.com>
Gerrit-Reviewer: Nico Huber <nico.h at gmx.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-Comment-Date: Fri, 25 Aug 2017 16:58:29 +0000
Gerrit-HasComments: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20170825/389f861e/attachment.html>