<p>Nico Huber <strong>posted comments</strong> on this change.</p><p><a href="https://review.coreboot.org/21178">View Change</a></p><p>Patch set 4:</p><p>(2 comments)</p><ul style="list-style: none; padding-left: 20px;"><li><p><a href="https://review.coreboot.org/#/c/21178/4/src/southbridge/intel/bd82x6x/pch.c">File src/southbridge/intel/bd82x6x/pch.c:</a></p><ul style="list-style: none; padding-left: 20px;"><li><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/21178/4/src/southbridge/intel/bd82x6x/pch.c@312">Patch Set #4, Line 312:</a> <code style="font-family:monospace,monospace">old_hotplug_map</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">Using `config->pcie_hotplug_map` here instead would make it more<br>clear, IMHO (e.g. you don't need the implicit information where<br>`old_hotplug_map` points to, to see what is going on).</p><p style="white-space: pre-wrap; word-wrap: break-word;">(The comment doesn't help to see that either.)</p></li><li><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/21178/4/src/southbridge/intel/bd82x6x/pch.c@419">Patch Set #4, Line 419:</a> <code style="font-family:monospace,monospace">                   pch_pcie_devicetree_update();</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">If you pass `config` here, you can probably drop all the if's above.</p></li></ul></li></ul><p>To view, visit <a href="https://review.coreboot.org/21178">change 21178</a>. To unsubscribe, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/21178"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: comment </div>
<div style="display:none"> Gerrit-Change-Id: I28c4eaf82fb52fe793dfa2f824f14686b80951ad </div>
<div style="display:none"> Gerrit-Change-Number: 21178 </div>
<div style="display:none"> Gerrit-PatchSet: 4 </div>
<div style="display:none"> Gerrit-Owner: Bill XIE <persmule@gmail.com> </div>
<div style="display:none"> Gerrit-Reviewer: Arthur Heymans <arthur@aheymans.xyz> </div>
<div style="display:none"> Gerrit-Reviewer: Bill XIE <persmule@gmail.com> </div>
<div style="display:none"> Gerrit-Reviewer: Nico Huber <nico.h@gmx.de> </div>
<div style="display:none"> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> </div>
<div style="display:none"> Gerrit-Comment-Date: Fri, 25 Aug 2017 16:58:29 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>