[coreboot-gerrit] Change in coreboot[master]: sb/intel/bd82x6x: make hotplug map consistent to remapped ports

[Arthur Heymans (Code Review)]

Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/21178 )

Change subject: sb/intel/bd82x6x: make hotplug map consistent to remapped ports
......................................................................


Patch Set 2:

(3 comments)

https://review.coreboot.org/#/c/21178/2/src/southbridge/intel/bd82x6x/pch.c
File src/southbridge/intel/bd82x6x/pch.c:

https://review.coreboot.org/#/c/21178/2/src/southbridge/intel/bd82x6x/pch.c@266
PS2, Line 266: struct southbridge_intel_bd82x6x_config *config = NULL;
             : 	u8 *old_hotplug_map = NULL;
you could initialise them here instead of in the loop?


https://review.coreboot.org/#/c/21178/2/src/southbridge/intel/bd82x6x/pch.c@286
PS2, Line 286: config = dev->chip_info;
             : 		old_hotplug_map = config->pcie_hotplug_map;
doesn't need to be in the loop?

you might want to check if config is NULL


https://review.coreboot.org/#/c/21178/2/src/southbridge/intel/bd82x6x/pch.c@297
PS2, Line 297: (
no need for parentheses.



-- 
To view, visit https://review.coreboot.org/21178
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I28c4eaf82fb52fe793dfa2f824f14686b80951ad
Gerrit-Change-Number: 21178
Gerrit-PatchSet: 2
Gerrit-Owner: Bill XIE <persmule at gmail.com>
Gerrit-Reviewer: Arthur Heymans <arthur at aheymans.xyz>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-Comment-Date: Fri, 25 Aug 2017 14:51:01 +0000
Gerrit-HasComments: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20170825/74181633/attachment.html>