<p>Arthur Heymans <strong>posted comments</strong> on this change.</p><p><a href="https://review.coreboot.org/21178">View Change</a></p><p>Patch set 2:</p><p>(3 comments)</p><ul style="list-style: none; padding-left: 20px;"><li><p><a href="https://review.coreboot.org/#/c/21178/2/src/southbridge/intel/bd82x6x/pch.c">File src/southbridge/intel/bd82x6x/pch.c:</a></p><ul style="list-style: none; padding-left: 20px;"><li><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/21178/2/src/southbridge/intel/bd82x6x/pch.c@266">Patch Set #2, Line 266:</a> </p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;"><pre style="font-family: monospace,monospace; white-space: pre-wrap;">struct southbridge_intel_bd82x6x_config *config = NULL;<br>     u8 *old_hotplug_map = NULL;<br></pre></blockquote></p><p style="white-space: pre-wrap; word-wrap: break-word;">you could initialise them here instead of in the loop?</p></li><li><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/21178/2/src/southbridge/intel/bd82x6x/pch.c@286">Patch Set #2, Line 286:</a> </p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;"><pre style="font-family: monospace,monospace; white-space: pre-wrap;">config = dev->chip_info;<br>         old_hotplug_map = config->pcie_hotplug_map;<br></pre></blockquote></p><p style="white-space: pre-wrap; word-wrap: break-word;">doesn't need to be in the loop?</p><p style="white-space: pre-wrap; word-wrap: break-word;">you might want to check if config is NULL</p></li><li><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/21178/2/src/southbridge/intel/bd82x6x/pch.c@297">Patch Set #2, Line 297:</a> <code style="font-family:monospace,monospace">(</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">no need for parentheses.</p></li></ul></li></ul><p>To view, visit <a href="https://review.coreboot.org/21178">change 21178</a>. To unsubscribe, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/21178"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: comment </div>
<div style="display:none"> Gerrit-Change-Id: I28c4eaf82fb52fe793dfa2f824f14686b80951ad </div>
<div style="display:none"> Gerrit-Change-Number: 21178 </div>
<div style="display:none"> Gerrit-PatchSet: 2 </div>
<div style="display:none"> Gerrit-Owner: Bill XIE <persmule@gmail.com> </div>
<div style="display:none"> Gerrit-Reviewer: Arthur Heymans <arthur@aheymans.xyz> </div>
<div style="display:none"> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> </div>
<div style="display:none"> Gerrit-Comment-Date: Fri, 25 Aug 2017 14:51:01 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>