[coreboot-gerrit] Change in coreboot[master]: src/mainboard/intel/cannonlake: Add gpio support for cannonlake

[John Zhao (Code Review)]

John Zhao has posted comments on this change. ( https://review.coreboot.org/21139 )

Change subject: src/mainboard/intel/cannonlake: Add gpio support for cannonlake
......................................................................


Patch Set 2:

(1 comment)

https://review.coreboot.org/#/c/21139/1/src/mainboard/intel/cannonlake_rvp/variants/baseboard/gpio.c
File src/mainboard/intel/cannonlake_rvp/variants/baseboard/gpio.c:

https://review.coreboot.org/#/c/21139/1/src/mainboard/intel/cannonlake_rvp/variants/baseboard/gpio.c@30
PS1, Line 30: /* A7  : PRIQAB_GSP10_CS1B */
            : 	PAD_CFG_GPI_ACPI_SCI(GPP_A7, 20K_PU, PLTRST, NONE),
> i think you should put the comment after macro for the same pin.
The gpio pins configuration and comments format is consistent with other platforms like poppy.



-- 
To view, visit https://review.coreboot.org/21139
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia077a070979401fe7bd23bda110d2b66a038d9fc
Gerrit-Change-Number: 21139
Gerrit-PatchSet: 2
Gerrit-Owner: John Zhao <john.zhao at intel.corp-partner.google.com>
Gerrit-Reviewer: John Zhao <john.zhao at intel.com>
Gerrit-Reviewer: John Zhao <john.zhao at intel.corp-partner.google.com>
Gerrit-Reviewer: Lijian Zhao <lijian.zhao at intel.com>
Gerrit-Reviewer: Paul Menzel <paulepanter at users.sourceforge.net>
Gerrit-Reviewer: Pratikkumar V Prajapati <pratikkumar.v.prajapati at intel.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-Comment-Date: Tue, 22 Aug 2017 16:32:15 +0000
Gerrit-HasComments: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20170822/1291fa8e/attachment.html>