<p>John Zhao <strong>posted comments</strong> on this change.</p><p><a href="https://review.coreboot.org/21139">View Change</a></p><p>Patch set 2:</p><p>(1 comment)</p><ul style="list-style: none; padding-left: 20px;"><li><p><a href="https://review.coreboot.org/#/c/21139/1/src/mainboard/intel/cannonlake_rvp/variants/baseboard/gpio.c">File src/mainboard/intel/cannonlake_rvp/variants/baseboard/gpio.c:</a></p><ul style="list-style: none; padding-left: 20px;"><li><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/21139/1/src/mainboard/intel/cannonlake_rvp/variants/baseboard/gpio.c@30">Patch Set #1, Line 30:</a> </p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;"><pre style="font-family: monospace,monospace; white-space: pre-wrap;">/* A7  : PRIQAB_GSP10_CS1B */<br>    PAD_CFG_GPI_ACPI_SCI(GPP_A7, 20K_PU, PLTRST, NONE),<br></pre></blockquote></p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;">i think you should put the comment after macro for the same pin.</blockquote></p><p style="white-space: pre-wrap; word-wrap: break-word;">The gpio pins configuration and comments format is consistent with other platforms like poppy.</p></li></ul></li></ul><p>To view, visit <a href="https://review.coreboot.org/21139">change 21139</a>. To unsubscribe, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/21139"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: comment </div>
<div style="display:none"> Gerrit-Change-Id: Ia077a070979401fe7bd23bda110d2b66a038d9fc </div>
<div style="display:none"> Gerrit-Change-Number: 21139 </div>
<div style="display:none"> Gerrit-PatchSet: 2 </div>
<div style="display:none"> Gerrit-Owner: John Zhao <john.zhao@intel.corp-partner.google.com> </div>
<div style="display:none"> Gerrit-Reviewer: John Zhao <john.zhao@intel.com> </div>
<div style="display:none"> Gerrit-Reviewer: John Zhao <john.zhao@intel.corp-partner.google.com> </div>
<div style="display:none"> Gerrit-Reviewer: Lijian Zhao <lijian.zhao@intel.com> </div>
<div style="display:none"> Gerrit-Reviewer: Paul Menzel <paulepanter@users.sourceforge.net> </div>
<div style="display:none"> Gerrit-Reviewer: Pratikkumar V Prajapati <pratikkumar.v.prajapati@intel.com> </div>
<div style="display:none"> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> </div>
<div style="display:none"> Gerrit-Comment-Date: Tue, 22 Aug 2017 16:32:15 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>