[coreboot-gerrit] Change in coreboot[master]: sb/intel/common/spi.c: Port to i82801gx

[Patrick Rudolph (Code Review)]

Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/21113 )

Change subject: sb/intel/common/spi.c: Port to i82801gx
......................................................................


Patch Set 3:

(3 comments)

https://review.coreboot.org/#/c/21113/3/src/southbridge/intel/common/spi.c
File src/southbridge/intel/common/spi.c:

https://review.coreboot.org/#/c/21113/3/src/southbridge/intel/common/spi.c@342
PS3, Line 342: 	if ((cntlr.hsfs & HSFS_FDV) && !IS_ENABLED(CONFIG_SOUTHBRIDGE_INTEL_I82801GX))
move into else block ?


https://review.coreboot.org/#/c/21113/3/src/southbridge/intel/common/spi.c@678
PS3, Line 678: 	u32 mask = IS_ENABLED(CONFIG_SOUTHBRIDGE_INTEL_I82801GX) ? 0x00ffffff
const


https://review.coreboot.org/#/c/21113/3/src/southbridge/intel/common/spi.c@680
PS3, Line 680: 	uint32_t addr_old = readl_(cntlr.addr) & ~mask;
const



-- 
To view, visit https://review.coreboot.org/21113
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I39199f3279a8b76e290b6693adc50dc2ac0ccf23
Gerrit-Change-Number: 21113
Gerrit-PatchSet: 3
Gerrit-Owner: Arthur Heymans <arthur at aheymans.xyz>
Gerrit-Reviewer: Arthur Heymans <arthur at aheymans.xyz>
Gerrit-Reviewer: Nico Huber <nico.h at gmx.de>
Gerrit-Reviewer: Patrick Rudolph <siro at das-labor.org>
Gerrit-Reviewer: Paul Menzel <paulepanter at users.sourceforge.net>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-Comment-Date: Tue, 22 Aug 2017 11:39:16 +0000
Gerrit-HasComments: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20170822/8c394d79/attachment.html>