<p>Patrick Rudolph <strong>posted comments</strong> on this change.</p><p><a href="https://review.coreboot.org/21113">View Change</a></p><p>Patch set 3:</p><p>(3 comments)</p><ul style="list-style: none; padding-left: 20px;"><li><p><a href="https://review.coreboot.org/#/c/21113/3/src/southbridge/intel/common/spi.c">File src/southbridge/intel/common/spi.c:</a></p><ul style="list-style: none; padding-left: 20px;"><li><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/21113/3/src/southbridge/intel/common/spi.c@342">Patch Set #3, Line 342:</a> <code style="font-family:monospace,monospace">     if ((cntlr.hsfs & HSFS_FDV) && !IS_ENABLED(CONFIG_SOUTHBRIDGE_INTEL_I82801GX))</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">move into else block ?</p></li><li><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/21113/3/src/southbridge/intel/common/spi.c@678">Patch Set #3, Line 678:</a> <code style="font-family:monospace,monospace"> u32 mask = IS_ENABLED(CONFIG_SOUTHBRIDGE_INTEL_I82801GX) ? 0x00ffffff</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">const</p></li><li><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/21113/3/src/southbridge/intel/common/spi.c@680">Patch Set #3, Line 680:</a> <code style="font-family:monospace,monospace">       uint32_t addr_old = readl_(cntlr.addr) & ~mask;</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">const</p></li></ul></li></ul><p>To view, visit <a href="https://review.coreboot.org/21113">change 21113</a>. To unsubscribe, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/21113"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: comment </div>
<div style="display:none"> Gerrit-Change-Id: I39199f3279a8b76e290b6693adc50dc2ac0ccf23 </div>
<div style="display:none"> Gerrit-Change-Number: 21113 </div>
<div style="display:none"> Gerrit-PatchSet: 3 </div>
<div style="display:none"> Gerrit-Owner: Arthur Heymans <arthur@aheymans.xyz> </div>
<div style="display:none"> Gerrit-Reviewer: Arthur Heymans <arthur@aheymans.xyz> </div>
<div style="display:none"> Gerrit-Reviewer: Nico Huber <nico.h@gmx.de> </div>
<div style="display:none"> Gerrit-Reviewer: Patrick Rudolph <siro@das-labor.org> </div>
<div style="display:none"> Gerrit-Reviewer: Paul Menzel <paulepanter@users.sourceforge.net> </div>
<div style="display:none"> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> </div>
<div style="display:none"> Gerrit-Comment-Date: Tue, 22 Aug 2017 11:39:16 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>