[coreboot-gerrit] Change in coreboot[master]: google/beltino: fix LED polarity for mccloud variant

[Matt DeVillier (Code Review)]

Matt DeVillier has uploaded this change for review. ( https://review.coreboot.org/21102


Change subject: google/beltino: fix LED polarity for mccloud variant
......................................................................

google/beltino: fix LED polarity for mccloud variant

The LED polarity was set incorrectly, fix using values derived
from original Chromium sources:
branch firmware-mccloud-5827.B, ToT
src/mainboard/google/mccloud/smihandler.c
src/mainboard/google/mccloud/romstage.c

TEST: boot google/mccloud, observe power LED on normally,
blinking in S4/S4, and off in S5.

Change-Id: Ia1f63eebbccb48fcf8543188db390b23045d843e
Signed-off-by: Matt DeVillier <matt.devillier at gmail.com>
---
M src/mainboard/google/beltino/variants/mccloud/led.c
1 file changed, 1 insertion(+), 1 deletion(-)



  git pull ssh://review.coreboot.org:29418/coreboot refs/changes/02/21102/1

diff --git a/src/mainboard/google/beltino/variants/mccloud/led.c b/src/mainboard/google/beltino/variants/mccloud/led.c
index ce8d2d8..b47e50a 100644
--- a/src/mainboard/google/beltino/variants/mccloud/led.c
+++ b/src/mainboard/google/beltino/variants/mccloud/led.c
@@ -22,7 +22,7 @@
 	it8772f_gpio_led(IT8772F_GPIO_DEV,
 		1, 					/* set */
 		0x01, 					/* select */
-		state == LED_OFF ? 0x00 : 0x01,		/* polarity */
+		state == LED_BLINK ? 0x01 : 0x00,	/* polarity */
 		state == LED_BLINK ? 0x01 : 0x00,	/* pullup/pulldown */
 		0x01, 					/* output */
 		state == LED_BLINK ? 0x00 : 0x01,	/* I/O function */

-- 
To view, visit https://review.coreboot.org/21102
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ia1f63eebbccb48fcf8543188db390b23045d843e
Gerrit-Change-Number: 21102
Gerrit-PatchSet: 1
Gerrit-Owner: Matt DeVillier <matt.devillier at gmail.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20170818/dc23858d/attachment.html>