<p>Matt DeVillier has uploaded this change for <strong>review</strong>.</p><p><a href="https://review.coreboot.org/21102">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">google/beltino: fix LED polarity for mccloud variant<br><br>The LED polarity was set incorrectly, fix using values derived<br>from original Chromium sources:<br>branch firmware-mccloud-5827.B, ToT<br>src/mainboard/google/mccloud/smihandler.c<br>src/mainboard/google/mccloud/romstage.c<br><br>TEST: boot google/mccloud, observe power LED on normally,<br>blinking in S4/S4, and off in S5.<br><br>Change-Id: Ia1f63eebbccb48fcf8543188db390b23045d843e<br>Signed-off-by: Matt DeVillier <matt.devillier@gmail.com><br>---<br>M src/mainboard/google/beltino/variants/mccloud/led.c<br>1 file changed, 1 insertion(+), 1 deletion(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://review.coreboot.org:29418/coreboot refs/changes/02/21102/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">diff --git a/src/mainboard/google/beltino/variants/mccloud/led.c b/src/mainboard/google/beltino/variants/mccloud/led.c<br>index ce8d2d8..b47e50a 100644<br>--- a/src/mainboard/google/beltino/variants/mccloud/led.c<br>+++ b/src/mainboard/google/beltino/variants/mccloud/led.c<br>@@ -22,7 +22,7 @@<br>       it8772f_gpio_led(IT8772F_GPIO_DEV,<br>            1,                                      /* set */<br>             0x01,                                   /* select */<br>-         state == LED_OFF ? 0x00 : 0x01,         /* polarity */<br>+               state == LED_BLINK ? 0x01 : 0x00,       /* polarity */<br>                state == LED_BLINK ? 0x01 : 0x00,       /* pullup/pulldown */<br>                 0x01,                                   /* output */<br>          state == LED_BLINK ? 0x00 : 0x01,       /* I/O function */<br></pre><p>To view, visit <a href="https://review.coreboot.org/21102">change 21102</a>. To unsubscribe, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/21102"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>
<div style="display:none"> Gerrit-Change-Id: Ia1f63eebbccb48fcf8543188db390b23045d843e </div>
<div style="display:none"> Gerrit-Change-Number: 21102 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Matt DeVillier <matt.devillier@gmail.com> </div>