[coreboot-gerrit] Change in coreboot[master]: soc/amd: Standardize guards on header files

[Marshall Dawson (Code Review)]

Marshall Dawson has posted comments on this change. ( https://review.coreboot.org/21073 )

Change subject: soc/amd: Standardize guards on header files
......................................................................


Patch Set 1:

(2 comments)

If you touch this patch again, you could also standardize the #endif /* __NAME_H__ */ .  Some have a tab after endif and others a single space.  Otherwise, meh.

https://review.coreboot.org/#/c/21073/1/src/soc/amd/common/dimmSpd.h
File src/soc/amd/common/dimmSpd.h:

https://review.coreboot.org/#/c/21073/1/src/soc/amd/common/dimmSpd.h@26
PS1, Line 26: #endif
I saw you added a comment in another file on an #endif.  I don't feel like one is needed here, but thought I'd mention it in case you left it out accidentally.


https://review.coreboot.org/#/c/21073/1/src/soc/amd/stoneyridge/include/soc/imc.h
File src/soc/amd/stoneyridge/include/soc/imc.h:

https://review.coreboot.org/#/c/21073/1/src/soc/amd/stoneyridge/include/soc/imc.h@27
PS1, Line 27: #endif
Same comment as before regarding the #endif.



-- 
To view, visit https://review.coreboot.org/21073
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4466df529ab201c922096a31d7438381778b582f
Gerrit-Change-Number: 21073
Gerrit-PatchSet: 1
Gerrit-Owner: Martin Roth <martinroth at google.com>
Gerrit-Reviewer: Marc Jones <marc at marcjonesconsulting.com>
Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd at gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-Comment-Date: Thu, 17 Aug 2017 22:53:33 +0000
Gerrit-HasComments: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20170817/70d2cfc6/attachment.html>