<p>Marshall Dawson <strong>posted comments</strong> on this change.</p><p><a href="https://review.coreboot.org/21073">View Change</a></p><p>Patch set 1:</p><p style="white-space: pre-wrap; word-wrap: break-word;">If you touch this patch again, you could also standardize the #endif /* __NAME_H__ */ .  Some have a tab after endif and others a single space.  Otherwise, meh.</p><p>(2 comments)</p><ul style="list-style: none; padding-left: 20px;"><li><p><a href="https://review.coreboot.org/#/c/21073/1/src/soc/amd/common/dimmSpd.h">File src/soc/amd/common/dimmSpd.h:</a></p><ul style="list-style: none; padding-left: 20px;"><li><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/21073/1/src/soc/amd/common/dimmSpd.h@26">Patch Set #1, Line 26:</a> <code style="font-family:monospace,monospace">#endif</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">I saw you added a comment in another file on an #endif.  I don't feel like one is needed here, but thought I'd mention it in case you left it out accidentally.</p></li></ul></li><li><p><a href="https://review.coreboot.org/#/c/21073/1/src/soc/amd/stoneyridge/include/soc/imc.h">File src/soc/amd/stoneyridge/include/soc/imc.h:</a></p><ul style="list-style: none; padding-left: 20px;"><li><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/21073/1/src/soc/amd/stoneyridge/include/soc/imc.h@27">Patch Set #1, Line 27:</a> <code style="font-family:monospace,monospace">#endif</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">Same comment as before regarding the #endif.</p></li></ul></li></ul><p>To view, visit <a href="https://review.coreboot.org/21073">change 21073</a>. To unsubscribe, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/21073"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: comment </div>
<div style="display:none"> Gerrit-Change-Id: I4466df529ab201c922096a31d7438381778b582f </div>
<div style="display:none"> Gerrit-Change-Number: 21073 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Martin Roth <martinroth@google.com> </div>
<div style="display:none"> Gerrit-Reviewer: Marc Jones <marc@marcjonesconsulting.com> </div>
<div style="display:none"> Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd@gmail.com> </div>
<div style="display:none"> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> </div>
<div style="display:none"> Gerrit-Comment-Date: Thu, 17 Aug 2017 22:53:33 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>