[coreboot-gerrit] Change in coreboot[master]: amd/padmelon: Fix SD controller setting

[John E. Kabat (Code Review)]

Hello Marshall Dawson,

I'd like you to do a code review. Please visit

    https://review.coreboot.org/21041

to review the following change.


Change subject: amd/padmelon: Fix SD controller setting
......................................................................

amd/padmelon: Fix SD controller setting

Remove the check for the board ID and downgrading the performance.
Also set the configuration for eMMC.

Change-Id: If01e426760138a3dc0487ba99ac87b35a939a958
Signed-off-by: Marshall Dawson <marshalldawson3rd at gmail.com>
---
M src/mainboard/amd/padmelon/BiosCallOuts.c
1 file changed, 1 insertion(+), 4 deletions(-)



  git pull ssh://review.coreboot.org:29418/coreboot refs/changes/41/21041/1

diff --git a/src/mainboard/amd/padmelon/BiosCallOuts.c b/src/mainboard/amd/padmelon/BiosCallOuts.c
index 5c11742..7abb69a 100644
--- a/src/mainboard/amd/padmelon/BiosCallOuts.c
+++ b/src/mainboard/amd/padmelon/BiosCallOuts.c
@@ -88,10 +88,7 @@
 
 		/* sata configuration */
 		/* SD configuration */
-		/* Rev F has an on-board eMMC, which only supports SD 2.0 */
-		if (board_id() == 'F') {
-			FchParams_env->Sd.SdConfig = SdVer2;
-		}
+		FchParams_env->Sd.SdSlotType = 1; /* eMMC */
 	}
 	printk(BIOS_DEBUG, "Done\n");
 

-- 
To view, visit https://review.coreboot.org/21041
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: If01e426760138a3dc0487ba99ac87b35a939a958
Gerrit-Change-Number: 21041
Gerrit-PatchSet: 1
Gerrit-Owner: John E. Kabat <sljkrr at gmail.com>
Gerrit-Reviewer: John E. Kabat Jr. <john.kabat at scarletltd.com>
Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd at gmail.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20170816/b7d62e56/attachment-0001.html>