<p>John E. Kabat would like Marshall Dawson to <strong>review</strong> this change.</p><p><a href="https://review.coreboot.org/21041">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">amd/padmelon: Fix SD controller setting<br><br>Remove the check for the board ID and downgrading the performance.<br>Also set the configuration for eMMC.<br><br>Change-Id: If01e426760138a3dc0487ba99ac87b35a939a958<br>Signed-off-by: Marshall Dawson <marshalldawson3rd@gmail.com><br>---<br>M src/mainboard/amd/padmelon/BiosCallOuts.c<br>1 file changed, 1 insertion(+), 4 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://review.coreboot.org:29418/coreboot refs/changes/41/21041/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">diff --git a/src/mainboard/amd/padmelon/BiosCallOuts.c b/src/mainboard/amd/padmelon/BiosCallOuts.c<br>index 5c11742..7abb69a 100644<br>--- a/src/mainboard/amd/padmelon/BiosCallOuts.c<br>+++ b/src/mainboard/amd/padmelon/BiosCallOuts.c<br>@@ -88,10 +88,7 @@<br> <br>                 /* sata configuration */<br>              /* SD configuration */<br>-               /* Rev F has an on-board eMMC, which only supports SD 2.0 */<br>-         if (board_id() == 'F') {<br>-                     FchParams_env->Sd.SdConfig = SdVer2;<br>-              }<br>+            FchParams_env->Sd.SdSlotType = 1; /* eMMC */<br>       }<br>     printk(BIOS_DEBUG, "Done\n");<br> <br></pre><p>To view, visit <a href="https://review.coreboot.org/21041">change 21041</a>. To unsubscribe, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/21041"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>
<div style="display:none"> Gerrit-Change-Id: If01e426760138a3dc0487ba99ac87b35a939a958 </div>
<div style="display:none"> Gerrit-Change-Number: 21041 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: John E. Kabat <sljkrr@gmail.com> </div>
<div style="display:none"> Gerrit-Reviewer: John E. Kabat Jr. <john.kabat@scarletltd.com> </div>
<div style="display:none"> Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd@gmail.com> </div>