[coreboot-gerrit] Change in coreboot[master]: drvs/lenovo/wacom: Clean ACPI code
Patrick Rudolph (Code Review)
gerrit at coreboot.org
Sun Aug 13 17:38:49 CEST 2017
Patrick Rudolph has uploaded this change for review. ( https://review.coreboot.org/20982
Change subject: drvs/lenovo/wacom: Clean ACPI code
......................................................................
drvs/lenovo/wacom: Clean ACPI code
Use acpigen method to return _STA instead of hardcoding unreadable bytecode.
Change-Id: I290fb918675857e8ef798e3ab820bcfbdc6f5bdc
Signed-off-by: Patrick Rudolph <siro at das-labor.org>
---
M src/drivers/lenovo/wacom.c
1 file changed, 2 insertions(+), 11 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/82/20982/1
diff --git a/src/drivers/lenovo/wacom.c b/src/drivers/lenovo/wacom.c
index d1464d7..f0f6ef8 100644
--- a/src/drivers/lenovo/wacom.c
+++ b/src/drivers/lenovo/wacom.c
@@ -105,11 +105,7 @@
acpigen_write_resourcetemplate_footer();
- acpigen_write_method("_STA", 0);
- /* return */
- acpigen_emit_byte(0xa4);
- acpigen_write_byte(0xf);
- acpigen_pop_len();
+ acpigen_write_STA(0xf);
acpigen_pop_len();
}
@@ -131,12 +127,7 @@
acpigen_write_resourcetemplate_footer();
- /* method op */
- acpigen_write_method("_STA", 0);
- /* return */
- acpigen_emit_byte(0xa4);
- acpigen_write_byte(0xf);
- acpigen_pop_len();
+ acpigen_write_STA(0xf);
acpigen_pop_len();
}
--
To view, visit https://review.coreboot.org/20982
To unsubscribe, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I290fb918675857e8ef798e3ab820bcfbdc6f5bdc
Gerrit-Change-Number: 20982
Gerrit-PatchSet: 1
Gerrit-Owner: Patrick Rudolph <siro at das-labor.org>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20170813/c455e25e/attachment-0001.html>
More information about the coreboot-gerrit
mailing list