<p>Patrick Rudolph has uploaded this change for <strong>review</strong>.</p><p><a href="https://review.coreboot.org/20982">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">drvs/lenovo/wacom: Clean ACPI code<br><br>Use acpigen method to return _STA instead of hardcoding unreadable bytecode.<br><br>Change-Id: I290fb918675857e8ef798e3ab820bcfbdc6f5bdc<br>Signed-off-by: Patrick Rudolph <siro@das-labor.org><br>---<br>M src/drivers/lenovo/wacom.c<br>1 file changed, 2 insertions(+), 11 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://review.coreboot.org:29418/coreboot refs/changes/82/20982/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">diff --git a/src/drivers/lenovo/wacom.c b/src/drivers/lenovo/wacom.c<br>index d1464d7..f0f6ef8 100644<br>--- a/src/drivers/lenovo/wacom.c<br>+++ b/src/drivers/lenovo/wacom.c<br>@@ -105,11 +105,7 @@<br> <br>             acpigen_write_resourcetemplate_footer();<br> <br>-          acpigen_write_method("_STA", 0);<br>-           /* return */<br>-         acpigen_emit_byte(0xa4);<br>-             acpigen_write_byte(0xf);<br>-             acpigen_pop_len();<br>+           acpigen_write_STA(0xf);<br> <br>            acpigen_pop_len();<br>    }<br>@@ -131,12 +127,7 @@<br> <br>            acpigen_write_resourcetemplate_footer();<br> <br>-          /* method op */<br>-              acpigen_write_method("_STA", 0);<br>-           /* return */<br>-         acpigen_emit_byte(0xa4);<br>-             acpigen_write_byte(0xf);<br>-             acpigen_pop_len();<br>+           acpigen_write_STA(0xf);<br> <br>            acpigen_pop_len();<br>    }<br></pre><p>To view, visit <a href="https://review.coreboot.org/20982">change 20982</a>. To unsubscribe, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/20982"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>
<div style="display:none"> Gerrit-Change-Id: I290fb918675857e8ef798e3ab820bcfbdc6f5bdc </div>
<div style="display:none"> Gerrit-Change-Number: 20982 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Patrick Rudolph <siro@das-labor.org> </div>