[coreboot-gerrit] Change in coreboot[master]: common/block/lpss: Add CLK read function into LPSS common

Subrata Banik (Code Review) gerrit at coreboot.org
Thu Aug 10 11:07:16 CEST 2017


Subrata Banik has uploaded this change for review. ( https://review.coreboot.org/20938


Change subject: common/block/lpss: Add CLK read function into LPSS common
......................................................................

common/block/lpss: Add CLK read function into LPSS common

This patch add new API to read LPSS CLK register along with
avoid multiple time write inside lpss_clk_update function.

Change-Id: I420919ad9154c4cf426bc232c5eb59d95fd698d2
Signed-off-by: Subrata Banik <subrata.banik at intel.com>
---
M src/soc/intel/common/block/include/intelblocks/lpss.h
M src/soc/intel/common/block/lpss/lpss.c
2 files changed, 14 insertions(+), 2 deletions(-)



  git pull ssh://review.coreboot.org:29418/coreboot refs/changes/38/20938/1

diff --git a/src/soc/intel/common/block/include/intelblocks/lpss.h b/src/soc/intel/common/block/include/intelblocks/lpss.h
index 03a4714..b2fb6c7 100644
--- a/src/soc/intel/common/block/include/intelblocks/lpss.h
+++ b/src/soc/intel/common/block/include/intelblocks/lpss.h
@@ -27,4 +27,7 @@
  */
 void lpss_clk_update(uintptr_t base, uint32_t clk_m_val, uint32_t clk_n_val);
 
+/* Read LPSS CLK register */
+uint32_t lpss_clk_read(uintptr_t base);
+
 #endif	/* SOC_INTEL_COMMON_BLOCK_LPSS_H */
diff --git a/src/soc/intel/common/block/lpss/lpss.c b/src/soc/intel/common/block/lpss/lpss.c
index 146fdab..da41903 100644
--- a/src/soc/intel/common/block/lpss/lpss.c
+++ b/src/soc/intel/common/block/lpss/lpss.c
@@ -54,7 +54,16 @@
 
 	addr += LPSS_CLOCK_CTL_REG;
 	clk_sel = LPSS_CLOCK_DIV_N(clk_n_val) | LPSS_CLOCK_DIV_M(clk_m_val);
+	clk_sel |= LPSS_CNT_CLK_UPDATE | LPSS_CNT_CLOCK_EN;
 
-	write32(addr, clk_sel | LPSS_CNT_CLK_UPDATE);
-	write32(addr, clk_sel | LPSS_CNT_CLOCK_EN);
+	write32(addr, clk_sel);
+}
+
+uint32_t lpss_clk_read(uintptr_t base)
+{
+	uint8_t *addr = (void *)base;
+
+	addr += LPSS_CLOCK_CTL_REG;
+
+	return read32(addr);
 }

-- 
To view, visit https://review.coreboot.org/20938
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I420919ad9154c4cf426bc232c5eb59d95fd698d2
Gerrit-Change-Number: 20938
Gerrit-PatchSet: 1
Gerrit-Owner: Subrata Banik <subrata.banik at intel.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20170810/0428c12e/attachment.html>


More information about the coreboot-gerrit mailing list