<p>Subrata Banik has uploaded this change for <strong>review</strong>.</p><p><a href="https://review.coreboot.org/20938">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">common/block/lpss: Add CLK read function into LPSS common<br><br>This patch add new API to read LPSS CLK register along with<br>avoid multiple time write inside lpss_clk_update function.<br><br>Change-Id: I420919ad9154c4cf426bc232c5eb59d95fd698d2<br>Signed-off-by: Subrata Banik <subrata.banik@intel.com><br>---<br>M src/soc/intel/common/block/include/intelblocks/lpss.h<br>M src/soc/intel/common/block/lpss/lpss.c<br>2 files changed, 14 insertions(+), 2 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://review.coreboot.org:29418/coreboot refs/changes/38/20938/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">diff --git a/src/soc/intel/common/block/include/intelblocks/lpss.h b/src/soc/intel/common/block/include/intelblocks/lpss.h<br>index 03a4714..b2fb6c7 100644<br>--- a/src/soc/intel/common/block/include/intelblocks/lpss.h<br>+++ b/src/soc/intel/common/block/include/intelblocks/lpss.h<br>@@ -27,4 +27,7 @@<br>  */<br> void lpss_clk_update(uintptr_t base, uint32_t clk_m_val, uint32_t clk_n_val);<br> <br>+/* Read LPSS CLK register */<br>+uint32_t lpss_clk_read(uintptr_t base);<br>+<br> #endif  /* SOC_INTEL_COMMON_BLOCK_LPSS_H */<br>diff --git a/src/soc/intel/common/block/lpss/lpss.c b/src/soc/intel/common/block/lpss/lpss.c<br>index 146fdab..da41903 100644<br>--- a/src/soc/intel/common/block/lpss/lpss.c<br>+++ b/src/soc/intel/common/block/lpss/lpss.c<br>@@ -54,7 +54,16 @@<br> <br>   addr += LPSS_CLOCK_CTL_REG;<br>   clk_sel = LPSS_CLOCK_DIV_N(clk_n_val) | LPSS_CLOCK_DIV_M(clk_m_val);<br>+ clk_sel |= LPSS_CNT_CLK_UPDATE | LPSS_CNT_CLOCK_EN;<br> <br>-       write32(addr, clk_sel | LPSS_CNT_CLK_UPDATE);<br>-        write32(addr, clk_sel | LPSS_CNT_CLOCK_EN);<br>+  write32(addr, clk_sel);<br>+}<br>+<br>+uint32_t lpss_clk_read(uintptr_t base)<br>+{<br>+  uint8_t *addr = (void *)base;<br>+<br>+     addr += LPSS_CLOCK_CTL_REG;<br>+<br>+       return read32(addr);<br> }<br></pre><p>To view, visit <a href="https://review.coreboot.org/20938">change 20938</a>. To unsubscribe, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/20938"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>
<div style="display:none"> Gerrit-Change-Id: I420919ad9154c4cf426bc232c5eb59d95fd698d2 </div>
<div style="display:none"> Gerrit-Change-Number: 20938 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Subrata Banik <subrata.banik@intel.com> </div>