[coreboot-gerrit] Change in coreboot[master]: mb/lenovo/x200: Add ACPI methods to set battery thresholds

[Nico Huber (Code Review)]

Nico Huber has posted comments on this change. ( https://review.coreboot.org/20913 )

Change subject: mb/lenovo/x200: Add ACPI methods to set battery thresholds
......................................................................


Patch Set 4:

(1 comment)

> Why don't you use existing interface to make coreboot compatible
> with tpacpi-bat and thinkpad_acpi?

I think a diff of patch set 3 and 4 answers the question: Left-hand
side looks good, right-hand side looks like shit.

https://review.coreboot.org/#/c/20913/3/src/mainboard/lenovo/x200/acpi/bat_thresh.asl
File src/mainboard/lenovo/x200/acpi/bat_thresh.asl:

https://review.coreboot.org/#/c/20913/3/src/mainboard/lenovo/x200/acpi/bat_thresh.asl@38
PS3, Line 38: 	 *     =0: Use battery default setting
Why is there a space after `Store` but not after `Or`?



-- 
To view, visit https://review.coreboot.org/20913
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia049407cea7a60887ecba7b7c96e5000473865dd
Gerrit-Change-Number: 20913
Gerrit-PatchSet: 4
Gerrit-Owner: Arthur Heymans <arthur at aheymans.xyz>
Gerrit-Reviewer: Arthur Heymans <arthur at aheymans.xyz>
Gerrit-Reviewer: Nico Huber <nico.h at gmx.de>
Gerrit-Reviewer: Patrick Rudolph <siro at das-labor.org>
Gerrit-Comment-Date: Wed, 09 Aug 2017 10:28:55 +0000
Gerrit-HasComments: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20170809/6a67e121/attachment.html>