[coreboot-gerrit] Change in coreboot[master]: mb/lenovo/x200: Add ACPI methods to set battery thresholds

[Arthur Heymans (Code Review)]

Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/20913 )

Change subject: mb/lenovo/x200: Add ACPI methods to set battery thresholds
......................................................................


Patch Set 4:

(1 comment)

https://review.coreboot.org/#/c/20913/4/src/mainboard/lenovo/x200/acpi/bat_thresh.asl
File src/mainboard/lenovo/x200/acpi/bat_thresh.asl:

https://review.coreboot.org/#/c/20913/4/src/mainboard/lenovo/x200/acpi/bat_thresh.asl@34
PS4, Line 34: 	/* SetBatteryCharge Start/Stop Capacity Threshold
            : 	 * In Parameter:
            : 	 * DWORD
            : 	 * Bit 7-0: Charge stop capacity (Unit:%)
            : 	 *     =0: Use battery default setting
            : 	 *     =1-99: Threshold to stop charging battery (Relative capacity)
            : 	 * Bit 9-8:BatteryID
            : 	 *    = 0: Any battery
            : 	 *    = 1: Primary battery
            : 	 *    = 2: Secondary battery
            : 	 *    = Others: Reserved (0)
            : 	 * Bit 31-10: Reserved (0)
            : 	 *     Must be Zero
            : 	 *
            : 	 * Out Parameter:
            : 	 * DWORD
            : 	 * Bit 30-0: Reserved (0)
            : 	 * Bit 31:     Error status
            : 	 *  0 ... Success
            : 	 *  1 ... Fail
            : 	 */
These comments are taken from the tpacpi-bat (https://github.com/teleshoes/tpacpi-bat) project documentation which afaict is GPL3. IANAL so is this acceptable or does it need a rewrite?



-- 
To view, visit https://review.coreboot.org/20913
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia049407cea7a60887ecba7b7c96e5000473865dd
Gerrit-Change-Number: 20913
Gerrit-PatchSet: 4
Gerrit-Owner: Arthur Heymans <arthur at aheymans.xyz>
Gerrit-Reviewer: Arthur Heymans <arthur at aheymans.xyz>
Gerrit-Reviewer: Nico Huber <nico.h at gmx.de>
Gerrit-Reviewer: Patrick Rudolph <siro at das-labor.org>
Gerrit-Comment-Date: Wed, 09 Aug 2017 08:37:01 +0000
Gerrit-HasComments: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20170809/8bde08ef/attachment.html>