[coreboot-gerrit] Change in coreboot[master]: mb/lenovo/x1_carbon_gen1: add missing '+' in spd/Makefile
Alexander Couzens (Code Review)
gerrit at coreboot.org
Wed Aug 9 03:33:04 CEST 2017
Alexander Couzens has uploaded this change for review. ( https://review.coreboot.org/20918
Change subject: mb/lenovo/x1_carbon_gen1: add missing '+' in spd/Makefile
......................................................................
mb/lenovo/x1_carbon_gen1: add missing '+' in spd/Makefile
Each line of spd config overwriting the slot 0 instead
of appending it.
Change-Id: I0124aa34f1d4fcb30810fb7eef03d4828a7ac430
Signed-off-by: Alexander Couzens <lynxis at fe80.eu>
Tested-on: lenovo x1 carbon gen 1 with elpida 8GB
Fixes: e9787ff61f81 ("mb/lenovo/x1_carbon_gen1: Add 4GiB SPD index 2")
---
M src/mainboard/lenovo/x1_carbon_gen1/spd/Makefile.inc
1 file changed, 2 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/18/20918/1
diff --git a/src/mainboard/lenovo/x1_carbon_gen1/spd/Makefile.inc b/src/mainboard/lenovo/x1_carbon_gen1/spd/Makefile.inc
index ec6e4f3..0c90826 100644
--- a/src/mainboard/lenovo/x1_carbon_gen1/spd/Makefile.inc
+++ b/src/mainboard/lenovo/x1_carbon_gen1/spd/Makefile.inc
@@ -16,8 +16,8 @@
SPD_BIN = $(obj)/spd.bin
SPD_SOURCES = elpida.hex # 0b0000 Single Channel 2GB
-SPD_SOURCES = samsung.hex # 0b0001 placeholder
-SPD_SOURCES = samsung.hex # 0b0010 4GiB
+SPD_SOURCES += samsung.hex # 0b0001 placeholder
+SPD_SOURCES += samsung.hex # 0b0010 4GiB
SPD_DEPS := $(foreach f, $(SPD_SOURCES), src/mainboard/$(MAINBOARDDIR)/spd/$(f))
# Include spd ROM data
--
To view, visit https://review.coreboot.org/20918
To unsubscribe, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I0124aa34f1d4fcb30810fb7eef03d4828a7ac430
Gerrit-Change-Number: 20918
Gerrit-PatchSet: 1
Gerrit-Owner: Alexander Couzens <lynxis at fe80.eu>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20170809/2e5d0d1b/attachment.html>
More information about the coreboot-gerrit
mailing list