<p>Alexander Couzens has uploaded this change for <strong>review</strong>.</p><p><a href="https://review.coreboot.org/20918">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">mb/lenovo/x1_carbon_gen1: add missing '+' in spd/Makefile<br><br>Each line of spd config overwriting the slot 0 instead<br>of appending it.<br><br>Change-Id: I0124aa34f1d4fcb30810fb7eef03d4828a7ac430<br>Signed-off-by: Alexander Couzens <lynxis@fe80.eu><br>Tested-on: lenovo x1 carbon gen 1 with elpida 8GB<br>Fixes: e9787ff61f81 ("mb/lenovo/x1_carbon_gen1: Add 4GiB SPD index 2")<br>---<br>M src/mainboard/lenovo/x1_carbon_gen1/spd/Makefile.inc<br>1 file changed, 2 insertions(+), 2 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://review.coreboot.org:29418/coreboot refs/changes/18/20918/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">diff --git a/src/mainboard/lenovo/x1_carbon_gen1/spd/Makefile.inc b/src/mainboard/lenovo/x1_carbon_gen1/spd/Makefile.inc<br>index ec6e4f3..0c90826 100644<br>--- a/src/mainboard/lenovo/x1_carbon_gen1/spd/Makefile.inc<br>+++ b/src/mainboard/lenovo/x1_carbon_gen1/spd/Makefile.inc<br>@@ -16,8 +16,8 @@<br> SPD_BIN = $(obj)/spd.bin<br> <br> SPD_SOURCES  = elpida.hex    # 0b0000 Single Channel 2GB<br>-SPD_SOURCES  = samsung.hex   # 0b0001 placeholder<br>-SPD_SOURCES  = samsung.hex   # 0b0010 4GiB<br>+SPD_SOURCES  += samsung.hex  # 0b0001 placeholder<br>+SPD_SOURCES  += samsung.hex  # 0b0010 4GiB<br> SPD_DEPS := $(foreach f, $(SPD_SOURCES), src/mainboard/$(MAINBOARDDIR)/spd/$(f))<br> <br> # Include spd ROM data<br></pre><p>To view, visit <a href="https://review.coreboot.org/20918">change 20918</a>. To unsubscribe, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/20918"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>
<div style="display:none"> Gerrit-Change-Id: I0124aa34f1d4fcb30810fb7eef03d4828a7ac430 </div>
<div style="display:none"> Gerrit-Change-Number: 20918 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Alexander Couzens <lynxis@fe80.eu> </div>