[coreboot-gerrit] Change in coreboot[master]: nb/intel/x4x/gma.c: Probe VGA EDID on DVI-I ports

[Arthur Heymans (Code Review)]

Arthur Heymans has uploaded this change for review. ( https://review.coreboot.org/20890


Change subject: nb/intel/x4x/gma.c: Probe VGA EDID on DVI-I ports
......................................................................

nb/intel/x4x/gma.c: Probe VGA EDID on DVI-I ports

This allows the use of the native VGA init on boards featuring DVI-I
ports.

TODO: check if the display is actually an analog display.

Change-Id: I11a4dd68746e06c7e27ecf3e765bdd0d8cf40515
Signed-off-by: Arthur Heymans <arthur at aheymans.xyz>
---
M src/northbridge/intel/x4x/gma.c
1 file changed, 11 insertions(+), 1 deletion(-)



  git pull ssh://review.coreboot.org:29418/coreboot refs/changes/90/20890/1

diff --git a/src/northbridge/intel/x4x/gma.c b/src/northbridge/intel/x4x/gma.c
index e91d778..a71ef83 100644
--- a/src/northbridge/intel/x4x/gma.c
+++ b/src/northbridge/intel/x4x/gma.c
@@ -74,6 +74,15 @@
 	u32 pixel_m1 = 1;
 	u32 pixel_m2 = 1;
 
+	vga_gmbus = GMBUS_PORT_VGADDC;
+
+	if (IS_ENABLED(GFX_GMA_ANALOG_I2C_HDMI_B))
+		vga_gmbus = GMBUS_PORT_DPB;
+	else if (IS_ENABLED(GFX_GMA_ANALOG_I2C_HDMI_C))
+		vga_gmbus = GMBUS_PORT_DPC;
+	else if (IS_ENABLED(GFX_GMA_ANALOG_I2C_HDMI_D))
+		vga_gmbus = GMBUS_PORT_DPD;
+
 	vga_gr_write(0x18, 0);
 
 	/* Set up GTT */
@@ -113,7 +122,8 @@
 
 	udelay(1);
 
-	intel_gmbus_read_edid(mmio + GMBUS0, GMBUS_PORT_VGADDC, 0x50, edid_data,
+	/* FIXME: check if it is actually an analog display */
+	intel_gmbus_read_edid(mmio + GMBUS0, vga_gmbus, 0x50, edid_data,
 			sizeof(edid_data));
 	intel_gmbus_stop(mmio + GMBUS0);
 	decode_edid(edid_data,

-- 
To view, visit https://review.coreboot.org/20890
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I11a4dd68746e06c7e27ecf3e765bdd0d8cf40515
Gerrit-Change-Number: 20890
Gerrit-PatchSet: 1
Gerrit-Owner: Arthur Heymans <arthur at aheymans.xyz>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20170806/6680d08d/attachment.html>